From: andy.shevchenko@gmail.com
To: andy.shevchenko@gmail.com
Cc: "Rodríguez Barbarin,
José Javier" <JoseJavier.Rodriguez@duagon.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"jirislaby@kernel.org" <jirislaby@kernel.org>,
"morbidrsa@gmail.com" <morbidrsa@gmail.com>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jth@kernel.org" <jth@kernel.org>,
"Sanjuán García, Jorge" <Jorge.SanjuanGarcia@duagon.com>
Subject: Re: [PATCH 3/3] 8250_men_mcb: Make UART config auto configurable
Date: Wed, 26 Jul 2023 13:32:23 +0300 [thread overview]
Message-ID: <ZMD2N3qNIhsuwMIr@surfacebook> (raw)
In-Reply-To: <ZMDc_krXXhoT2jwn@surfacebook>
Wed, Jul 26, 2023 at 11:44:46AM +0300, andy.shevchenko@gmail.com kirjoitti:
> Wed, Jul 05, 2023 at 01:15:14PM +0000, Rodríguez Barbarin, José Javier kirjoitti:
> > The UART ports created by this driver were not usable out of
> > the box, so let the configuration be handled by the 8250 UART
> > subsystem. This makes the implementation simpler and the UART
> > port more usable.
> >
> > The 8250 UART subsystem will take care of requesting the memory
> > resources, but the driver needs to first read the register where
> > the num ports is set, so a request of the resource is needed
> > before registering the UART port.
>
> I see this is already pending to the next cylce, but
> formally I would like to NAK this change as explained
> in reply to cover letter why.
Okay, after a bit of digging it seems not so bad as I was thinking initially.
The IRQ test requires specific flag which seems is not set in this case.
This removes my main worries.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-07-26 10:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 13:14 [PATCH 0/3] 8250_men_mcb: Make UART port autoconfigurable Rodríguez Barbarin, José Javier
2023-07-05 13:15 ` [PATCH 1/3] 8250_men_mcb: Add clockrate speed for G215/F215 boards Rodríguez Barbarin, José Javier
2023-07-05 13:15 ` [PATCH 2/3] 8250_men_mcb: Read num ports from register data Rodríguez Barbarin, José Javier
2023-07-05 13:15 ` [PATCH 3/3] 8250_men_mcb: Make UART config auto configurable Rodríguez Barbarin, José Javier
2023-07-26 8:44 ` andy.shevchenko
2023-07-26 10:32 ` andy.shevchenko [this message]
2023-07-26 8:42 ` [PATCH 0/3] 8250_men_mcb: Make UART port autoconfigurable andy.shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMD2N3qNIhsuwMIr@surfacebook \
--to=andy.shevchenko@gmail.com \
--cc=Jorge.SanjuanGarcia@duagon.com \
--cc=JoseJavier.Rodriguez@duagon.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=jth@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=morbidrsa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).