From: andy.shevchenko@gmail.com
To: "Rodríguez Barbarin, José Javier" <JoseJavier.Rodriguez@duagon.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"jirislaby@kernel.org" <jirislaby@kernel.org>,
"morbidrsa@gmail.com" <morbidrsa@gmail.com>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jth@kernel.org" <jth@kernel.org>,
"Sanjuán García, Jorge" <Jorge.SanjuanGarcia@duagon.com>
Subject: Re: [PATCH 0/3] 8250_men_mcb: Make UART port autoconfigurable
Date: Wed, 26 Jul 2023 11:42:25 +0300 [thread overview]
Message-ID: <ZMDccXK4N4ZEwsPn@surfacebook> (raw)
In-Reply-To: <20230705131423.30552-1-josejavier.rodriguez@duagon.com>
Wed, Jul 05, 2023 at 01:14:51PM +0000, Rodríguez Barbarin, José Javier kirjoitti:
> Make configuration be handled by the 8250 UART subsystem
Actually this is not the best idea.
> to avoid weird behaviours
The opposite.
8250 detection is full of quirks and was developed to handle tons of different
UARTs when the driver was in a single file. Since you have a separate 8250_*.c
module for your UART and you _know_ the type beforehand, why on earth you need
to rely on the old and maybe not very suitable code? Have you thought about
corner cases with IRQ detection, for example?
> and for better maintainability.
The opposite.
I don't know if it affects your hardware to the date, but it may be different
for the future models, or models that you hadn't tested.
That said, I highly recommend to reconsider.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-07-26 8:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 13:14 [PATCH 0/3] 8250_men_mcb: Make UART port autoconfigurable Rodríguez Barbarin, José Javier
2023-07-05 13:15 ` [PATCH 1/3] 8250_men_mcb: Add clockrate speed for G215/F215 boards Rodríguez Barbarin, José Javier
2023-07-05 13:15 ` [PATCH 2/3] 8250_men_mcb: Read num ports from register data Rodríguez Barbarin, José Javier
2023-07-05 13:15 ` [PATCH 3/3] 8250_men_mcb: Make UART config auto configurable Rodríguez Barbarin, José Javier
2023-07-26 8:44 ` andy.shevchenko
2023-07-26 10:32 ` andy.shevchenko
2023-07-26 8:42 ` andy.shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMDccXK4N4ZEwsPn@surfacebook \
--to=andy.shevchenko@gmail.com \
--cc=Jorge.SanjuanGarcia@duagon.com \
--cc=JoseJavier.Rodriguez@duagon.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=jth@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=morbidrsa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).