From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jisheng Zhang <jszhang@kernel.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Jiri Slaby" <jirislaby@kernel.org>,
linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] serial: 8250_dw: fall back to poll if there's no interrupt
Date: Thu, 3 Aug 2023 00:56:00 +0300 [thread overview]
Message-ID: <ZMrQ8IXyqGqTKR79@smile.fi.intel.com> (raw)
In-Reply-To: <20230802150545.3742-3-jszhang@kernel.org>
On Wed, Aug 02, 2023 at 11:05:45PM +0800, Jisheng Zhang wrote:
> When there's no irq(this can be due to various reasons, for example,
> no irq from HW support, or we just want to use poll solution, and so
> on), falling back to poll is still better than no support at all.
...
> irq = platform_get_irq(pdev, 0);
You will still have an error message. Perhaps you need to replace it with
irq = platform_get_irq_optional(pdev, 0);
> - if (irq < 0)
> - return irq;
> + if (irq < 0) {
> + if (irq != -ENXIO)
> + return irq;
> + /* no interrupt -> fall back to polling */
> + irq = 0;
> + }
This can be slightly modified:
/* no interrupt -> fall back to polling */
if (irq == -ENXIO)
irq = 0;
if (irq < 0)
return irq;
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-08-02 21:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 15:05 [PATCH 0/2] serial: 8250_dw: fall back to poll if there's no interrupt Jisheng Zhang
2023-08-02 15:05 ` [PATCH 1/2] dt-bindings: serial: snps-dw-apb-uart: make interrupt optional Jisheng Zhang
2023-08-02 15:43 ` Conor Dooley
2023-08-02 21:57 ` Andy Shevchenko
2023-08-02 22:53 ` Conor Dooley
2023-08-03 11:40 ` Andy Shevchenko
2023-08-06 9:40 ` Jisheng Zhang
2023-08-02 15:05 ` [PATCH 2/2] serial: 8250_dw: fall back to poll if there's no interrupt Jisheng Zhang
2023-08-02 21:56 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMrQ8IXyqGqTKR79@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=jszhang@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).