From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "Tony Lindgren" <tony@atomide.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Dhruva Gole" <d-gole@ti.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"John Ogness" <john.ogness@linutronix.de>,
"Johan Hovold" <johan@kernel.org>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v5 3/3] serial: core: Fix serial core controller port name to show controller id
Date: Fri, 4 Aug 2023 07:20:45 +0300 [thread overview]
Message-ID: <ZMx8nQzYB3dBouFE@smile.fi.intel.com> (raw)
In-Reply-To: <6423de18-637e-4ee6-858e-b74e701ff3e5@roeck-us.net>
On Thu, Aug 03, 2023 at 03:18:42PM -0700, Guenter Roeck wrote:
> On Tue, Jul 25, 2023 at 08:42:12AM +0300, Tony Lindgren wrote:
> > We are missing the serial core controller id for the serial core port
> > name. Let's fix the issue for sane sysfs output, and to avoid issues
> > addressing serial ports later on.
> >
> > And as we're now showing the controller id, the "ctrl" and "port" prefix
> > for the DEVNAME become useless, we can just drop them. Let's standardize on
> > DEVNAME:0 for controller name, where 0 is the controller id. And
> > DEVNAME:0.0 for port name, where 0.0 are the controller id and port id.
> >
> > This makes the sysfs output nicer, on qemu for example:
> >
> > $ ls /sys/bus/serial-base/devices
> > 00:04:0 serial8250:0 serial8250:0.2
> > 00:04:0.0 serial8250:0.1 serial8250:0.3
> >
> > Fixes: 84a9582fd203 ("serial: core: Start managing serial controllers to enable runtime PM")
> > Reported-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
>
> This patch causes about 50% of my boot tests to fail because the console
> is no longer recognized. Reverting this patch fixes the problem.
> Bisect log attached.
Isn't fix already available?
7d695d83767c ("serial: core: Fix serial_base_match() after fixing controller port name")
(in tty/tty-linus)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-04 4:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 5:42 [PATCH v5 0/3] Serial core controller port device name fixes Tony Lindgren
2023-07-25 5:42 ` [PATCH v5 1/3] serial: core: Controller id cannot be negative Tony Lindgren
2023-07-25 5:42 ` [PATCH v5 2/3] serial: core: Fix serial core port id to not use port->line Tony Lindgren
2023-07-25 5:42 ` [PATCH v5 3/3] serial: core: Fix serial core controller port name to show controller id Tony Lindgren
2023-07-25 9:07 ` Andy Shevchenko
2023-07-26 3:28 ` Tony Lindgren
2023-07-31 15:14 ` Greg Kroah-Hartman
2023-07-31 20:02 ` Andy Shevchenko
[not found] ` <202308021529.35b3ad6c-oliver.sang@intel.com>
2023-08-02 9:23 ` Tony Lindgren
2023-08-02 9:39 ` Greg Kroah-Hartman
2023-08-02 10:47 ` Tony Lindgren
2023-08-02 11:52 ` Tony Lindgren
2023-08-02 18:19 ` Mark Brown
2023-08-03 6:52 ` Tony Lindgren
2023-08-03 22:18 ` Guenter Roeck
2023-08-04 4:20 ` Andy Shevchenko [this message]
2023-08-04 4:38 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMx8nQzYB3dBouFE@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=d-gole@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).