From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B18BC04A6A for ; Fri, 4 Aug 2023 04:20:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231339AbjHDEUz (ORCPT ); Fri, 4 Aug 2023 00:20:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231316AbjHDEUy (ORCPT ); Fri, 4 Aug 2023 00:20:54 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1833F3AB1; Thu, 3 Aug 2023 21:20:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691122851; x=1722658851; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=XfgFdFaPZzAwY62NpMVOgR5DKzyUu6HyS+eVaO3NlDc=; b=LUZobZ3W44DujQ/MtwDg1FRcTHpliiC/LZ1HB9csHNNsSHpLbt/oOdBQ PNqp3TOH8WfHve9HX/mPCPUMVt0nAQPz5pK6hlECo0T0R/rYOU7sgqDZD IpRutsKafUaqNuiosjZZhTORnrzzsAWudRci4Z4zlzj9nYlZbU7/EI7KT XGMC25tdnvMG8KFvjvl7BOepGjrFH3VPgvy1ge5VOSB3sVvGH9pPrxCeq L2GfIr704MlMNxICL4RZxtWcuY3lNc8JDiW54me4nCHQYwmNwKTgBLwJ+ snB60pB0OEsPilDSD1Wb4jYnt31lMHILVbyQmpWobOEV1UWYEDAIWNRia Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10791"; a="456435643" X-IronPort-AV: E=Sophos;i="6.01,254,1684825200"; d="scan'208";a="456435643" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Aug 2023 21:20:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10791"; a="706824176" X-IronPort-AV: E=Sophos;i="6.01,254,1684825200"; d="scan'208";a="706824176" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga006.jf.intel.com with ESMTP; 03 Aug 2023 21:20:47 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qRmIv-009Hs3-1k; Fri, 04 Aug 2023 07:20:45 +0300 Date: Fri, 4 Aug 2023 07:20:45 +0300 From: Andy Shevchenko To: Guenter Roeck Cc: Tony Lindgren , Greg Kroah-Hartman , Jiri Slaby , Dhruva Gole , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , John Ogness , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v5 3/3] serial: core: Fix serial core controller port name to show controller id Message-ID: References: <20230725054216.45696-1-tony@atomide.com> <20230725054216.45696-4-tony@atomide.com> <6423de18-637e-4ee6-858e-b74e701ff3e5@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6423de18-637e-4ee6-858e-b74e701ff3e5@roeck-us.net> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Thu, Aug 03, 2023 at 03:18:42PM -0700, Guenter Roeck wrote: > On Tue, Jul 25, 2023 at 08:42:12AM +0300, Tony Lindgren wrote: > > We are missing the serial core controller id for the serial core port > > name. Let's fix the issue for sane sysfs output, and to avoid issues > > addressing serial ports later on. > > > > And as we're now showing the controller id, the "ctrl" and "port" prefix > > for the DEVNAME become useless, we can just drop them. Let's standardize on > > DEVNAME:0 for controller name, where 0 is the controller id. And > > DEVNAME:0.0 for port name, where 0.0 are the controller id and port id. > > > > This makes the sysfs output nicer, on qemu for example: > > > > $ ls /sys/bus/serial-base/devices > > 00:04:0 serial8250:0 serial8250:0.2 > > 00:04:0.0 serial8250:0.1 serial8250:0.3 > > > > Fixes: 84a9582fd203 ("serial: core: Start managing serial controllers to enable runtime PM") > > Reported-by: Andy Shevchenko > > Reviewed-by: Andy Shevchenko > > Signed-off-by: Tony Lindgren > > This patch causes about 50% of my boot tests to fail because the console > is no longer recognized. Reverting this patch fixes the problem. > Bisect log attached. Isn't fix already available? 7d695d83767c ("serial: core: Fix serial_base_match() after fixing controller port name") (in tty/tty-linus) -- With Best Regards, Andy Shevchenko