From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH v1 1/1] serial: core: Remove unused PORT_* definitions
Date: Mon, 21 Aug 2023 11:24:42 +0300 [thread overview]
Message-ID: <ZOMfSorbfxIYMwkJ@smile.fi.intel.com> (raw)
In-Reply-To: <ZOMe2NIMp+a8ShsX@smile.fi.intel.com>
On Mon, Aug 21, 2023 at 11:22:49AM +0300, Andy Shevchenko wrote:
> On Fri, Aug 18, 2023 at 02:12:29PM +0300, Andy Shevchenko wrote:
> > For the last couple of years Linux kernel got rid of a few architectures
> > and many platforms. Hence some PORT_* definitions in the serial_core.h
> > become unused and redundant. Remove them for good.
>
> Below are results via Debian Code Search.
>
> Note, I excluded Linux kernel itself from the "user" and Hurd, which seems
> to have Linux kernel v2.6 which is _provider_ of the definition(s).
...
> > -#define PORT_RM9000 16 /* PMC-Sierra RM9xxx internal UART */
>
> ifdeffed, safe to remove.
Actually on the second thought, this can bring a collision in case someone adds
another ID with the same value.
I'll issue the v2 with this line left untouched.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-08-21 8:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 11:12 [PATCH v1 1/1] serial: core: Remove unused PORT_* definitions Andy Shevchenko
2023-08-19 9:53 ` Greg Kroah-Hartman
2023-08-21 8:14 ` Andy Shevchenko
2023-08-21 8:22 ` Andy Shevchenko
2023-08-21 8:24 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOMfSorbfxIYMwkJ@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).