From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Justin Chen <justin.chen@broadcom.com>
Cc: linux-serial@vger.kernel.org, "Al Cooper" <alcooperx@gmail.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"John Ogness" <john.ogness@linutronix.de>,
"Jiaqing Zhao" <jiaqing.zhao@linux.intel.com>,
"open list:TTY LAYER" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] serial: 8250_bcm7271: improve bcm7271 8250 port
Date: Mon, 21 Aug 2023 11:45:40 +0300 [thread overview]
Message-ID: <ZOMkNKwUBtoikb3q@smile.fi.intel.com> (raw)
In-Reply-To: <7332fd46-0310-8fdd-81a6-4ac722a6eda4@broadcom.com>
On Fri, Aug 18, 2023 at 12:22:25PM -0700, Justin Chen wrote:
> On 8/18/23 3:59 AM, Andy Shevchenko wrote:
> > On Thu, Aug 17, 2023 at 02:13:18PM -0700, Justin Chen wrote:
...
> > > +/* Broadcom BCM7271 UART */
> > > +#define PORT_BCM7271 76
> >
> > 13 is free why not using it?
>
> I was looking for a number close to another Broadcom port. I was
> prioritizing locality. But I have no issues with 13, I will change in v3.
Please, don't. I realized that they are defined in different file.
So, the first gap is 43. but I would like to compress the list first.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-21 8:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 21:13 [PATCH v2] serial: 8250_bcm7271: improve bcm7271 8250 port Justin Chen
2023-08-18 10:59 ` Andy Shevchenko
2023-08-18 19:22 ` Justin Chen
2023-08-21 8:45 ` Andy Shevchenko [this message]
2023-08-18 19:37 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOMkNKwUBtoikb3q@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alcooperx@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jiaqing.zhao@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=justin.chen@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).