From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 835E3EE4996 for ; Tue, 22 Aug 2023 11:38:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235192AbjHVLiH (ORCPT ); Tue, 22 Aug 2023 07:38:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235138AbjHVLh4 (ORCPT ); Tue, 22 Aug 2023 07:37:56 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1A251BE; Tue, 22 Aug 2023 04:37:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692704252; x=1724240252; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=qTy2dsEMxoSY4LsyRuCSkODsgDqQ6tQo1/+kl7l0kv0=; b=k8jHIvrvcL/XB4HSw2lgKH/RWh/GEI+tiXyOB5EVaRqifrCXp4FWaLyA Cr33tlhUdb/GK3219quTix7gZQ/WHlCNdI2mToDJ+6Fh+JMXWZc+qDXO+ rhYQ7KC858MxfzvyaYLghkjrwfz/ExekcEWKiBOVm6SwGmzMW1TgZgywO WKfYgh66DDyXr/cIe+aMIIVEf7p/9tvmD3x3AZUWPRQ//90ct0NALWYFa trLP74mYLqndxCluOAdTiLUWFOMBeyyu6hHF6GXfuP6KD0XQXFp4jd2Qg dBc4OBW/HlLYbwU+CwFp1i6NP7NlYP7EKZqXHuwvNnTThyuiWEU3AY62W Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="377612957" X-IronPort-AV: E=Sophos;i="6.01,192,1684825200"; d="scan'208";a="377612957" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2023 04:36:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="826302594" X-IronPort-AV: E=Sophos;i="6.01,192,1684825200"; d="scan'208";a="826302594" Received: from smile.fi.intel.com ([10.237.72.54]) by FMSMGA003.fm.intel.com with ESMTP; 22 Aug 2023 04:36:25 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qYPgN-008MbU-0o; Tue, 22 Aug 2023 14:36:23 +0300 Date: Tue, 22 Aug 2023 14:36:22 +0300 From: Andy Shevchenko To: Justin Chen Cc: linux-serial@vger.kernel.org, Al Cooper , Broadcom internal kernel review list , Greg Kroah-Hartman , Jiri Slaby , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Florian Fainelli , John Ogness , Jiaqing Zhao , "open list:TTY LAYER" Subject: Re: [PATCH v4] serial: 8250_bcm7271: improve bcm7271 8250 port Message-ID: References: <1692643978-16570-1-git-send-email-justin.chen@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1692643978-16570-1-git-send-email-justin.chen@broadcom.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Mon, Aug 21, 2023 at 11:52:51AM -0700, Justin Chen wrote: > The 8250 BCM7271 UART is not a direct match to PORT_16550A and other > generic ports do not match its hardware capabilities. PORT_ALTR matches > the rx trigger levels, but its vendor configurations are not compatible. > Unfortunately this means we need to create another port to fully capture > the hardware capabilities of the BCM7271 UART. > > To alleviate some latency pressures, we default the rx trigger level to 8. FWIW, Reviewed-by: Andy Shevchenko ... > + [PORT_BCM7271] = { > + .name = "Broadcom BCM7271 UART", > + .fifo_size = 32, > + .tx_loadsz = 32, > + .fcr = UART_FCR_ENABLE_FIFO | UART_FCR_R_TRIG_01, > + .rxtrig_bytes = {1, 8, 16, 30}, > + .flags = UART_CAP_FIFO | UART_CAP_AFE, > + }, Strictly speaking it's better to keep this ordered according to the number, but it's fine like this anyway. -- With Best Regards, Andy Shevchenko