Re: [PATCH V3 2/2] serial: exar: Add RS-485 support for Sealevel XR17V35X based cards

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Fri, Sep 01, 2023 at 10:26:01AM -0400, Matthew Howell wrote:
> On Thu, 31 Aug 2023, Andy Shevchenko wrote:
> > On Thu, Aug 31, 2023 at 03:48:08PM -0400, Matthew Howell wrote:

...

> > > +     if (rs485->flags & SER_RS485_ENABLED) {
> > 
> > Seems you haven't seen / ignored my comments. Please, read my previous reply.
> 
> You said !!() is redundant and I have removed !!(). Previous feedback also
> suggested that is_rs485 is not needed, but I had reverted both changes as 
> I initially thought it was the cause of a breakage. However, further testing 
> found the breakage was unrelated to this patch series. Therefore, I 
> attempted to address both suggestions by removing is_rs485 and !!() in 
> this submission.
> 
> I did not ignore your comments and I do not appreciate these insenuations. 

> I have made changes based on every one of your comments in the previous 
> submission, I just did not always address the comment in exactly you 
> suggested.
> 
> Please, clarify how this fails to address your comments and I will be 
> happy to correct it in the next submission.

I believe there is a misunderstanding in what I meant.
My previous comment was to change

	if (is_...) {
		...
	}
	return 0;

to

	if (!is_...)
		return 0;
	...
	return 0;

which is missing here. But as you said the entire "if" is redundant, so drop it.

> > > +    }

-- 
With Best Regards,
Andy Shevchenko