[PATCH V5 1/2] serial: exar: Revert "serial: exar: Add support for Sealevel 7xxxC serial cards"

[PATCH V5 1/2] serial: exar: Revert "serial: exar: Add support for Sealevel 7xxxC serial cards"

[Matthew Howell]

From: Matthew Howell <matthew.howell@sealevel.com>

Hardware ID of Sealevel 7xxxC cards changed prior to release. This has rendered 14ee78d5932a redundant.

Revert "serial: exar: Add support for Sealevel 7xxxC serial cards"

This reverts commit 14ee78d5932afeb710c8305196a676a715bfdea8.

Link: https://lore.kernel.org/all/72b3e74e-ced6-784c-01e0-8a851326a203@sealevel.com/T/
Fixes: 14ee78d5932a ("Add support for Sealevel 7xxxC serial cards")
Signed-off-by: Matthew Howell <matthew.howell@sealevel.com>
---
diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c
index 077c3ba3539e..3886f78ecbbf 100644
--- a/drivers/tty/serial/8250/8250_exar.c
+++ b/drivers/tty/serial/8250/8250_exar.c
@@ -47,12 +47,6 @@
 #define PCI_SUBDEVICE_ID_USR_2980		0x0128
 #define PCI_SUBDEVICE_ID_USR_2981		0x0129

-#define PCI_DEVICE_ID_SEALEVEL_710xC		0x1001
-#define PCI_DEVICE_ID_SEALEVEL_720xC		0x1002
-#define PCI_DEVICE_ID_SEALEVEL_740xC		0x1004
-#define PCI_DEVICE_ID_SEALEVEL_780xC		0x1008
-#define PCI_DEVICE_ID_SEALEVEL_716xC		0x1010
-
 #define UART_EXAR_INT0		0x80
 #define UART_EXAR_8XMODE	0x88	/* 8X sampling rate select */
 #define UART_EXAR_SLEEP		0x8b	/* Sleep mode */
@@ -652,8 +646,6 @@ exar_pci_probe(struct pci_dev *pcidev, const struct pci_device_id *ent)
 		nr_ports = BIT(((pcidev->device & 0x38) >> 3) - 1);
 	else if (board->num_ports)
 		nr_ports = board->num_ports;
-	else if (pcidev->vendor == PCI_VENDOR_ID_SEALEVEL)
-		nr_ports = pcidev->device & 0xff;
 	else
 		nr_ports = pcidev->device & 0x0f;

@@ -893,12 +885,6 @@ static const struct pci_device_id exar_pci_tbl[] = {
 	EXAR_DEVICE(COMMTECH, 4224PCI335, pbn_fastcom335_4),
 	EXAR_DEVICE(COMMTECH, 2324PCI335, pbn_fastcom335_4),
 	EXAR_DEVICE(COMMTECH, 2328PCI335, pbn_fastcom335_8),
-
-	EXAR_DEVICE(SEALEVEL, 710xC, pbn_exar_XR17V35x),
-	EXAR_DEVICE(SEALEVEL, 720xC, pbn_exar_XR17V35x),
-	EXAR_DEVICE(SEALEVEL, 740xC, pbn_exar_XR17V35x),
-	EXAR_DEVICE(SEALEVEL, 780xC, pbn_exar_XR17V35x),
-	EXAR_DEVICE(SEALEVEL, 716xC, pbn_exar_XR17V35x),
 	{ 0, }
 };
 MODULE_DEVICE_TABLE(pci, exar_pci_tbl);

Re: [PATCH V5 1/2] serial: exar: Revert "serial: exar: Add support for Sealevel 7xxxC serial cards"

[Andy Shevchenko]

On Thu, Sep 14, 2023 at 08:28:47AM -0400, Matthew Howell wrote:
> From: Matthew Howell <matthew.howell@sealevel.com>
> 
> Hardware ID of Sealevel 7xxxC cards changed prior to release. This has rendered 14ee78d5932a redundant.

Too long line.

> Revert "serial: exar: Add support for Sealevel 7xxxC serial cards"
> 
> This reverts commit 14ee78d5932afeb710c8305196a676a715bfdea8.
> 
> Link: https://lore.kernel.org/all/72b3e74e-ced6-784c-01e0-8a851326a203@sealevel.com/T/
> Fixes: 14ee78d5932a ("Add support for Sealevel 7xxxC serial cards")
> Signed-off-by: Matthew Howell <matthew.howell@sealevel.com>

The patch 1 and patch 2 have not been linked via email, so mail archives and
mail clients do not see this as a thread. I suggest to use `git send-email` for
patches. With --thread option (which I believe should be default) it chains
the mails it sends.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH V5 1/2] serial: exar: Revert "serial: exar: Add support for Sealevel 7xxxC serial cards"

[Matthew Howell]

On Thu, 14 Sep 2023, Andy Shevchenko wrote:
> On Thu, Sep 14, 2023 at 08:28:47AM -0400, Matthew Howell wrote:
> > From: Matthew Howell <matthew.howell@sealevel.com>
> >
> > Hardware ID of Sealevel 7xxxC cards changed prior to release. This has rendered 14ee78d5932a redundant.
> 
> Too long line.
> 
> > Revert "serial: exar: Add support for Sealevel 7xxxC serial cards"
> >
> > This reverts commit 14ee78d5932afeb710c8305196a676a715bfdea8.
> >
> > Link: https://lore.kernel.org/all/72b3e74e-ced6-784c-01e0-8a851326a203@sealevel.com/T/
> > Fixes: 14ee78d5932a ("Add support for Sealevel 7xxxC serial cards")
> > Signed-off-by: Matthew Howell <matthew.howell@sealevel.com>
> 
> The patch 1 and patch 2 have not been linked via email, so mail archives and
> mail clients do not see this as a thread. I suggest to use `git send-email` for
> patches. With --thread option (which I believe should be default) it chains
> the mails it sends.

I have not seen any way to setup git send-mail with this email as git 
send-email seems to lack OAUTH2. If you can set it up with OAUTH2 & O365  
I have not been able to find any documentation or guides on how to do 
this.

> --
> With Best Regards,
> Andy Shevchenko 
 

Re: [PATCH V5 1/2] serial: exar: Revert "serial: exar: Add support for Sealevel 7xxxC serial cards"

[Greg KH]

On Thu, Sep 14, 2023 at 03:51:26PM -0400, Matthew Howell wrote:
> On Thu, 14 Sep 2023, Andy Shevchenko wrote:
> > On Thu, Sep 14, 2023 at 08:28:47AM -0400, Matthew Howell wrote:
> > > From: Matthew Howell <matthew.howell@sealevel.com>
> > >
> > > Hardware ID of Sealevel 7xxxC cards changed prior to release. This has rendered 14ee78d5932a redundant.
> > 
> > Too long line.
> > 
> > > Revert "serial: exar: Add support for Sealevel 7xxxC serial cards"
> > >
> > > This reverts commit 14ee78d5932afeb710c8305196a676a715bfdea8.
> > >
> > > Link: https://lore.kernel.org/all/72b3e74e-ced6-784c-01e0-8a851326a203@sealevel.com/T/
> > > Fixes: 14ee78d5932a ("Add support for Sealevel 7xxxC serial cards")
> > > Signed-off-by: Matthew Howell <matthew.howell@sealevel.com>
> > 
> > The patch 1 and patch 2 have not been linked via email, so mail archives and
> > mail clients do not see this as a thread. I suggest to use `git send-email` for
> > patches. With --thread option (which I believe should be default) it chains
> > the mails it sends.
> 
> I have not seen any way to setup git send-mail with this email as git 
> send-email seems to lack OAUTH2. If you can set it up with OAUTH2 & O365  
> I have not been able to find any documentation or guides on how to do 
> this.

If you are using mutt, just respond to the first patch with the second
one.  Otherwise our tools really don't like dis-joined patch series and
I have to dig them out by hand :(

I'll do so for this one, but in the future, please fix up.

thanks,

greg k-h

Re: [PATCH V5 1/2] serial: exar: Revert "serial: exar: Add support for Sealevel 7xxxC serial cards"

[Andy Shevchenko]

On Thu, Sep 14, 2023 at 03:51:26PM -0400, Matthew Howell wrote:
> On Thu, 14 Sep 2023, Andy Shevchenko wrote:
> > On Thu, Sep 14, 2023 at 08:28:47AM -0400, Matthew Howell wrote:
> > > From: Matthew Howell <matthew.howell@sealevel.com>
> > >
> > > Hardware ID of Sealevel 7xxxC cards changed prior to release. This has rendered 14ee78d5932a redundant.
> > 
> > Too long line.
> > 
> > > Revert "serial: exar: Add support for Sealevel 7xxxC serial cards"
> > >
> > > This reverts commit 14ee78d5932afeb710c8305196a676a715bfdea8.
> > >
> > > Link: https://lore.kernel.org/all/72b3e74e-ced6-784c-01e0-8a851326a203@sealevel.com/T/
> > > Fixes: 14ee78d5932a ("Add support for Sealevel 7xxxC serial cards")
> > > Signed-off-by: Matthew Howell <matthew.howell@sealevel.com>
> > 
> > The patch 1 and patch 2 have not been linked via email, so mail archives and
> > mail clients do not see this as a thread. I suggest to use `git send-email` for
> > patches. With --thread option (which I believe should be default) it chains
> > the mails it sends.
> 
> I have not seen any way to setup git send-mail with this email as git 
> send-email seems to lack OAUTH2. If you can set it up with OAUTH2 & O365  
> I have not been able to find any documentation or guides on how to do 
> this.

We have O365 at the company, but git send-email works transparently. Perhaps
you have to talk to the IT in yours.

For reading messages we are using email-oauth2-proxy python script (you may
find it on GitHub), it can also be configured for SMTP (in my case only IMAP is
in use).

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH V5 1/2] serial: exar: Revert "serial: exar: Add support for Sealevel 7xxxC serial cards"

[Matthew Howell]

On Mon, 18 Sep 2023, Greg KH wrote:
> On Thu, Sep 14, 2023 at 03:51:26PM -0400, Matthew Howell wrote:
> > On Thu, 14 Sep 2023, Andy Shevchenko wrote:
> > > On Thu, Sep 14, 2023 at 08:28:47AM -0400, Matthew Howell wrote:
> > > > From: Matthew Howell <matthew.howell@sealevel.com>
> > > >
> > > > Hardware ID of Sealevel 7xxxC cards changed prior to release. This has rendered 14ee78d5932a redundant.
> > >
> > > Too long line.
> > >
> > > > Revert "serial: exar: Add support for Sealevel 7xxxC serial cards"
> > > >
> > > > This reverts commit 14ee78d5932afeb710c8305196a676a715bfdea8.
> > > >
> > > > Link: https://lore.kernel.org/all/72b3e74e-ced6-784c-01e0-8a851326a203@sealevel.com/T/
> > > > Fixes: 14ee78d5932a ("Add support for Sealevel 7xxxC serial cards")
> > > > Signed-off-by: Matthew Howell <matthew.howell@sealevel.com>
> > >
> > > The patch 1 and patch 2 have not been linked via email, so mail archives and
> > > mail clients do not see this as a thread. I suggest to use `git send-email` for
> > > patches. With --thread option (which I believe should be default) it chains
> > > the mails it sends.
> >
> > I have not seen any way to setup git send-mail with this email as git
> > send-email seems to lack OAUTH2. If you can set it up with OAUTH2 & O365
> > I have not been able to find any documentation or guides on how to do
> > this.
> 
> If you are using mutt, just respond to the first patch with the second
> one.  Otherwise our tools really don't like dis-joined patch series and
> I have to dig them out by hand :(

I understand. I've been doing that (but in Alpine), it just seems like 
it failed to thread on the most recent submissions for some reason, but 
I'm not sure why. I will take a look at the headers next time before 
sending the reply to make sure it is adding the in-reply-to header 
correctly.

> I'll do so for this one, but in the future, please fix up.
> 
> thanks,
> 
> greg k-h
>