From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Matthew Howell <matthew.howell@sealevel.com>
Cc: gregkh@linuxfoundation.org, jeff.baldwin@sealevel.com,
james.olson@sealevel.com, ryan.wenglarz@sealevel.com,
darren.beeson@sealevel.com, linux-serial@vger.kernel.org,
ilpo.jarvinen@linux.intel.com
Subject: Re: [PATCH V7 2/2] serial: exar: Add RS-485 support for Sealevel XR17V35X based cards
Date: Thu, 21 Sep 2023 14:10:53 +0300 [thread overview]
Message-ID: <ZQwkvSUM9ojfmuj3@smile.fi.intel.com> (raw)
In-Reply-To: <d44f91c4-4599-1911-5cfb-bfc3cde95a9b@sealevel.com>
On Wed, Sep 20, 2023 at 03:03:02PM -0400, Matthew Howell wrote:
>
> From: Matthew Howell <matthew.howell@sealevel.com>
>
> Sealevel XR17V35X based cards utilize DTR to control RS-485 Enable, but
> the current implementation of 8250_exar uses RTS for the auto-RS485-Enable
> mode of the XR17V35X UARTs. This patch implements DTR Auto-RS485 on
> Sealevel cards.
If you address the following couple of things, feel free to add
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
...
> Hopefully Alpine threads correctly this time
Nope.
...
> +static int sealevel_rs485_config(struct uart_port *port, struct ktermios *termios,
> + struct serial_rs485 *rs485)
Misindented second line (missing one space?).
...
> + ret = generic_rs485_config(port, termios, rs485);
> +
Unneeded blank line.
> + if (ret)
> + return ret;
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-09-21 18:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 19:03 [PATCH V7 2/2] serial: exar: Add RS-485 support for Sealevel XR17V35X based cards Matthew Howell
2023-09-21 11:10 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQwkvSUM9ojfmuj3@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=darren.beeson@sealevel.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=james.olson@sealevel.com \
--cc=jeff.baldwin@sealevel.com \
--cc=linux-serial@vger.kernel.org \
--cc=matthew.howell@sealevel.com \
--cc=ryan.wenglarz@sealevel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox