From: Crescent CY Hsieh <crescentcy.hsieh@moxa.com>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH 1/4] tty: serial: 8250: Cleanup MOXA configurations in 8250_pci.c
Date: Tue, 3 Oct 2023 15:17:47 +0800 [thread overview]
Message-ID: <ZRvAG5336KxuugVd@moxa-ThinkCentre-M90t> (raw)
In-Reply-To: <68d533d5-dbc8-4be3-a1fc-b3dd28b8f9df@kernel.org>
On Mon, Oct 02, 2023 at 08:51:03AM +0200, Jiri Slaby wrote:
> On 02. 10. 23, 3:56, Crescent CY Hsieh wrote:
> > @@ -1958,6 +1958,9 @@ pci_moxa_setup(struct serial_private *priv,
> > #define PCIE_DEVICE_ID_WCH_CH384_8S 0x3853
> > #define PCIE_DEVICE_ID_WCH_CH382_2S 0x3253
> > +/* MOXA */
> > +#define PCI_VENDOR_ID_MOXA 0x1393
>
> Isn't this a redefinition of the pci-ids.h one?
At first, I attempt to place DEVICE_ID macros into pci_ids.h to enable
their usage throughout 8250_pci.c and to establish centralized
management. However, I notice the comment in pci_ids.h which is:
'Do not add new entries to this file unless the definitions are shared
between multiple drivers'
So I add this VENDOR_ID just for the clarity, even though it results in
duplication.
Should I put these macros into pci_ids.h? If so, I am willing to help
relocate all other macros.
---
Sincerely,
Crescent CY Hsieh
next prev parent reply other threads:[~2023-10-03 7:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 1:56 [PATCH 0/4] tty: serial: 8250: Changes of MOXA PCIe boards in 8250_pci.c Crescent CY Hsieh
2023-10-02 1:56 ` [PATCH 1/4] tty: serial: 8250: Cleanup MOXA configurations " Crescent CY Hsieh
2023-10-02 6:51 ` Jiri Slaby
2023-10-03 7:17 ` Crescent CY Hsieh [this message]
2023-10-03 7:30 ` Greg KH
2023-10-03 9:49 ` Jiri Slaby
2023-10-02 1:57 ` [PATCH 2/4] tty: serial: 8250: Add support for MOXA Mini PCIe boards Crescent CY Hsieh
2023-10-02 7:05 ` Jiri Slaby
2023-10-03 8:17 ` Crescent CY Hsieh
2023-10-02 1:57 ` [PATCH 3/4] tty: serial: 8250: Fix MOXA RS422/RS485 PCIe boards not work by default Crescent CY Hsieh
2023-10-02 7:14 ` Jiri Slaby
2023-10-03 8:22 ` Crescent CY Hsieh
2023-10-02 1:57 ` [PATCH 4/4] tty: serial: 8250: Add support for MOXA PCIe boards to switch interface between RS422/RS485 Crescent CY Hsieh
2023-10-02 4:13 ` kernel test robot
2023-10-02 5:47 ` kernel test robot
2023-10-02 7:19 ` Jiri Slaby
2023-10-03 9:57 ` Crescent CY Hsieh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRvAG5336KxuugVd@moxa-ThinkCentre-M90t \
--to=crescentcy.hsieh@moxa.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox