From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Al Cooper <alcooperx@gmail.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH v1 1/1] serial: 8250_bcm7271: Use devm_clk_get_optional_enabled()
Date: Tue, 3 Oct 2023 17:48:29 +0300 [thread overview]
Message-ID: <ZRwpvYn9xSm3+F/T@smile.fi.intel.com> (raw)
In-Reply-To: <20231003141241.3071687-1-andriy.shevchenko@linux.intel.com>
On Tue, Oct 03, 2023 at 05:12:41PM +0300, Andy Shevchenko wrote:
Seems the old version had been sent...
...
> + baud_mux_clk = devm_clk_get_optional_enabled(dev, "sw_baud");
Here should be
ret = PTR_ERR_OR_ZERO(baud_mux_clk);
> + if (IS_ERR(baud_mux_clk))
if (ret)
> + goto release_dma;
...I'll send a v2 later on. Sorry for the noise.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-10-03 14:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 14:12 [PATCH v1 1/1] serial: 8250_bcm7271: Use devm_clk_get_optional_enabled() Andy Shevchenko
2023-10-03 14:48 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRwpvYn9xSm3+F/T@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alcooperx@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox