From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Tony Lindgren <tony@atomide.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Rob Herring" <robh@kernel.org>, "Dhruva Gole" <d-gole@ti.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"John Ogness" <john.ogness@linutronix.de>,
"Johan Hovold" <johan@kernel.org>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
"Maximilian Luz" <luzmaximilian@gmail.com>
Subject: Re: [RFC PATCH 1/2] serial: core: Move tty and serdev to be children of serial core port device
Date: Tue, 24 Oct 2023 15:43:33 +0300 [thread overview]
Message-ID: <ZTe79akvB0OYwG3a@smile.fi.intel.com> (raw)
In-Reply-To: <ZTe11rbKgcusPRD/@smile.fi.intel.com>
On Tue, Oct 24, 2023 at 03:17:26PM +0300, Andy Shevchenko wrote:
> On Tue, Oct 24, 2023 at 02:36:18PM +0300, Tony Lindgren wrote:
...
> > - ctrl->dev.of_node = parent->of_node;
> > + ctrl->dev.of_node = host->of_node;
>
> Even above should have been using device_set_node(&ctrl->dev, dev_fwnode(host)).
...
> > /* Make sure controller and ResourceSource handle match */
> > - if (ACPI_HANDLE(ctrl->dev.parent) != lookup.controller_handle)
> > + if (ACPI_HANDLE(ctrl->host) != lookup.controller_handle)
>
> This can be changed to use device_match_acpi_handle().
>
> > return -ENODEV;
...
> > - if (!has_acpi_companion(ctrl->dev.parent))
> > + if (!has_acpi_companion(ctrl->host))
>
> I prefer is_acpi_device_node(dev_fwnode(...)) check, but here seems no other
> use for fwnode (haven't checked the full context, though).
>
> > return -ENODEV;
...
I have just sent a little series based on these comments.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-10-24 12:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 11:36 [RFC PATCH 1/2] serial: core: Move tty and serdev to be children of serial core port device Tony Lindgren
2023-10-24 11:36 ` [RFC PATCH 2/2] serial: core: Revert checks for tx runtime PM state Tony Lindgren
2023-10-24 11:52 ` [RFC PATCH 1/2] serial: core: Move tty and serdev to be children of serial core port device Greg Kroah-Hartman
2023-10-24 12:29 ` Tony Lindgren
2023-10-24 12:42 ` Andy Shevchenko
2023-10-24 12:45 ` Tony Lindgren
2023-10-24 14:01 ` Greg Kroah-Hartman
2023-10-25 6:51 ` Tony Lindgren
2023-10-25 7:33 ` Johan Hovold
2023-10-25 8:24 ` Tony Lindgren
2023-10-24 12:17 ` Andy Shevchenko
2023-10-24 12:43 ` Andy Shevchenko [this message]
2023-10-25 6:53 ` Tony Lindgren
2023-10-24 12:48 ` Johan Hovold
2023-10-24 13:37 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTe79akvB0OYwG3a@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=bigeasy@linutronix.de \
--cc=d-gole@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=robh@kernel.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).