From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hugo Villeneuve <hugo@hugovil.com>
Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org,
jringle@gridpoint.com, kubakici@wp.pl, phil@raspberrypi.org,
bo.svangard@embeddedart.se, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org,
Hugo Villeneuve <hvilleneuve@dimonoff.com>
Subject: Re: [PATCH 05/18] serial: sc16is7xx: use DECLARE_BITMAP for sc16is7xx_lines bitfield
Date: Wed, 20 Dec 2023 17:45:55 +0200 [thread overview]
Message-ID: <ZYMMM9uaoKD39oPy@smile.fi.intel.com> (raw)
In-Reply-To: <20231219171903.3530985-6-hugo@hugovil.com>
On Tue, Dec 19, 2023 at 12:18:49PM -0500, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>
> Replace the explicit sc16is7xx_lines bitfield declaration with the generic
> macro DECLARE_BITMAP() to reserve just enough memory to contain all
> required bits.
>
> This also improves code self-documentation by showing the maximum number
> of bits required.
>
> This conversion now makes sc16is7xx_lines an array, so drop the "&" before
> sc16is7xx_lines in all bit access functions.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-12-20 15:48 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 17:18 [PATCH 00/18] serial: sc16is7xx: fixes, cleanups and improvements Hugo Villeneuve
2023-12-19 17:18 ` [PATCH 01/18] serial: sc16is7xx: fix segfault when removing driver Hugo Villeneuve
2023-12-20 15:34 ` Andy Shevchenko
2023-12-20 15:38 ` Andy Shevchenko
2023-12-19 17:18 ` [PATCH 02/18] serial: sc16is7xx: fix invalid sc16is7xx_lines bitfield in case of probe error Hugo Villeneuve
2023-12-20 15:40 ` Andy Shevchenko
2023-12-21 15:56 ` Hugo Villeneuve
2023-12-21 16:05 ` Andy Shevchenko
2023-12-21 16:13 ` Hugo Villeneuve
2023-12-21 16:16 ` Andy Shevchenko
2023-12-21 17:13 ` Hugo Villeneuve
2023-12-19 17:18 ` [PATCH 03/18] serial: sc16is7xx: remove obsolete loop in sc16is7xx_port_irq() Hugo Villeneuve
2023-12-20 15:41 ` Andy Shevchenko
2023-12-20 22:09 ` Hugo Villeneuve
2023-12-19 17:18 ` [PATCH 04/18] serial: sc16is7xx: improve do/while loop in sc16is7xx_irq() Hugo Villeneuve
2023-12-20 15:42 ` Andy Shevchenko
2023-12-20 16:00 ` Hugo Villeneuve
2023-12-19 17:18 ` [PATCH 05/18] serial: sc16is7xx: use DECLARE_BITMAP for sc16is7xx_lines bitfield Hugo Villeneuve
2023-12-20 15:45 ` Andy Shevchenko [this message]
2023-12-19 17:18 ` [PATCH 06/18] serial: sc16is7xx: use spi_get_device_match_data() Hugo Villeneuve
2023-12-20 15:44 ` Andy Shevchenko
2023-12-20 22:22 ` Hugo Villeneuve
2023-12-19 17:18 ` [PATCH 07/18] serial: sc16is7xx: use i2c_get_match_data() Hugo Villeneuve
2023-12-20 15:45 ` Andy Shevchenko
2023-12-19 17:18 ` [PATCH 08/18] serial: sc16is7xx: add driver name to struct uart_driver Hugo Villeneuve
2023-12-20 15:48 ` Andy Shevchenko
2023-12-20 16:11 ` Hugo Villeneuve
2023-12-20 18:59 ` Andy Shevchenko
2023-12-19 17:18 ` [PATCH 09/18] serial: sc16is7xx: add macro for max number of UART ports Hugo Villeneuve
2023-12-20 15:50 ` Andy Shevchenko
2023-12-21 16:41 ` Hugo Villeneuve
2023-12-21 16:55 ` Andy Shevchenko
2023-12-21 17:00 ` Hugo Villeneuve
2023-12-19 17:18 ` [PATCH 10/18] serial: sc16is7xx: use HZ_PER_MHZ macro to improve readability Hugo Villeneuve
2023-12-20 15:51 ` Andy Shevchenko
2023-12-19 17:18 ` [PATCH 11/18] serial: sc16is7xx: add explicit return for some switch default cases Hugo Villeneuve
2023-12-20 15:52 ` Andy Shevchenko
2023-12-19 17:18 ` [PATCH 12/18] serial: sc16is7xx: replace hardcoded divisor value with BIT() macro Hugo Villeneuve
2023-12-20 15:52 ` Andy Shevchenko
2023-12-19 17:18 ` [PATCH 13/18] serial: sc16is7xx: use in_range() for DT properties bound checks Hugo Villeneuve
2023-12-20 15:54 ` Andy Shevchenko
2023-12-20 16:24 ` Hugo Villeneuve
2023-12-19 17:18 ` [PATCH 14/18] serial: sc16is7xx: drop unneeded MODULE_ALIAS Hugo Villeneuve
2023-12-20 15:54 ` Andy Shevchenko
2023-12-20 16:21 ` Hugo Villeneuve
2023-12-19 17:18 ` [PATCH 15/18] serial: sc16is7xx: pass R/W buffer in FIFO functions Hugo Villeneuve
2023-12-20 15:57 ` Andy Shevchenko
2023-12-21 19:35 ` Hugo Villeneuve
2023-12-19 17:19 ` [PATCH 16/18] serial: sc16is7xx: reorder code to remove prototype declarations Hugo Villeneuve
2023-12-20 15:58 ` Andy Shevchenko
2023-12-20 16:30 ` Hugo Villeneuve
2023-12-20 19:00 ` Andy Shevchenko
2023-12-19 17:19 ` [PATCH 17/18] serial: sc16is7xx: refactor EFR lock Hugo Villeneuve
2023-12-20 16:03 ` Andy Shevchenko
2023-12-20 21:38 ` Hugo Villeneuve
2023-12-19 17:19 ` [PATCH 18/18] serial: sc16is7xx: fix whitespace in sc16is7xx_startup() comments Hugo Villeneuve
2023-12-20 16:04 ` Andy Shevchenko
2023-12-20 20:53 ` Hugo Villeneuve
2023-12-20 16:06 ` [PATCH 00/18] serial: sc16is7xx: fixes, cleanups and improvements Andy Shevchenko
2023-12-20 16:38 ` Hugo Villeneuve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYMMM9uaoKD39oPy@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bo.svangard@embeddedart.se \
--cc=gregkh@linuxfoundation.org \
--cc=hugo@hugovil.com \
--cc=hvilleneuve@dimonoff.com \
--cc=jirislaby@kernel.org \
--cc=jringle@gridpoint.com \
--cc=kubakici@wp.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=phil@raspberrypi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).