linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: serial: snps-dw-apb-uart: remove N1S binding
@ 2025-04-11 15:51 Wolfram Sang
  2025-04-11 16:23 ` Rob Herring
  0 siblings, 1 reply; 3+ messages in thread
From: Wolfram Sang @ 2025-04-11 15:51 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: Wolfram Sang, Greg Kroah-Hartman, Jiri Slaby, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Geert Uytterhoeven,
	Magnus Damm, linux-serial, devicetree

This is one of four (quite randomly) added bindings for Renesas RZ/N1S.
Essential bindings like clock support are missing for 8 years. With 6MB
of internal RAM only, N1S is not a prime candidate for running Linux,
unlike the DDR-RAM capable N1D. I could not find any further activity in
upstreaming N1S support, neither for Linux or any other OS. So, remove
these half-baked dangling bindings which are incomplete and look
unprofessional. We can happily add them back if somebody offers complete
support for it. Until then, let's enjoy the easier handling of a single
'const'.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---

This would render Geert's cleanup unnecessary:

https://lore.kernel.org/r/90c7aa143beb6a28255b24e8ef8c96180d869cbb.1744271974.git.geert+renesas@glider.be

 .../devicetree/bindings/serial/snps-dw-apb-uart.yaml | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
index 1aa3480d8d81..1ee0aed5057d 100644
--- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
+++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
@@ -17,9 +17,7 @@ allOf:
       properties:
         compatible:
           items:
-            - enum:
-                - renesas,r9a06g032-uart
-                - renesas,r9a06g033-uart
+            - const: renesas,r9a06g032-uart
             - const: renesas,rzn1-uart
             - const: snps,dw-apb-uart
     then:
@@ -45,15 +43,11 @@ properties:
   compatible:
     oneOf:
       - items:
-          - enum:
-              - renesas,r9a06g032-uart
-              - renesas,r9a06g033-uart
+          - const: renesas,r9a06g032-uart
           - const: renesas,rzn1-uart
           - const: snps,dw-apb-uart
       - items:
-          - enum:
-              - renesas,r9a06g032-uart
-              - renesas,r9a06g033-uart
+          - const: renesas,r9a06g032-uart
           - const: renesas,rzn1-uart
       - items:
           - enum:
-- 
2.47.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: serial: snps-dw-apb-uart: remove N1S binding
  2025-04-11 15:51 [PATCH] dt-bindings: serial: snps-dw-apb-uart: remove N1S binding Wolfram Sang
@ 2025-04-11 16:23 ` Rob Herring
  2025-04-11 19:22   ` Wolfram Sang
  0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2025-04-11 16:23 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: linux-renesas-soc, Greg Kroah-Hartman, Jiri Slaby,
	Krzysztof Kozlowski, Conor Dooley, Geert Uytterhoeven,
	Magnus Damm, linux-serial, devicetree

On Fri, Apr 11, 2025 at 10:52 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> This is one of four (quite randomly) added bindings for Renesas RZ/N1S.
> Essential bindings like clock support are missing for 8 years. With 6MB
> of internal RAM only, N1S is not a prime candidate for running Linux,
> unlike the DDR-RAM capable N1D. I could not find any further activity in
> upstreaming N1S support, neither for Linux or any other OS. So, remove
> these half-baked dangling bindings which are incomplete and look
> unprofessional. We can happily add them back if somebody offers complete
> support for it. Until then, let's enjoy the easier handling of a single
> 'const'.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> This would render Geert's cleanup unnecessary:
>
> https://lore.kernel.org/r/90c7aa143beb6a28255b24e8ef8c96180d869cbb.1744271974.git.geert+renesas@glider.be

To repeat from that thread, IMO, whether you drop the platform is
orthogonal to Geert's patch.

Seems like the platform is pretty dead. If you want to send a single
patch removing all the bindings, I can take it.

Rob

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: serial: snps-dw-apb-uart: remove N1S binding
  2025-04-11 16:23 ` Rob Herring
@ 2025-04-11 19:22   ` Wolfram Sang
  0 siblings, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2025-04-11 19:22 UTC (permalink / raw)
  To: Rob Herring
  Cc: linux-renesas-soc, Greg Kroah-Hartman, Jiri Slaby,
	Krzysztof Kozlowski, Conor Dooley, Geert Uytterhoeven,
	Magnus Damm, linux-serial, devicetree

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]


> Seems like the platform is pretty dead. If you want to send a single
> patch removing all the bindings, I can take it.

Yay, consider it done (in a few minutes).

Thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-04-11 19:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-11 15:51 [PATCH] dt-bindings: serial: snps-dw-apb-uart: remove N1S binding Wolfram Sang
2025-04-11 16:23 ` Rob Herring
2025-04-11 19:22   ` Wolfram Sang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).