From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BE4DA5C8E2; Fri, 23 Feb 2024 09:19:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.175.24.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708679969; cv=none; b=MEe3oWG31JWOPk2ozrFnK3CRRn5ov7YdDBJuMjWYD6ylSQ+1+CuZNEnGZHkX/8y2umJlCykSUlk4JXSdOCUp0sZ9XXbWQJ2fVMF7Gh/4k39/klmpf+gGcy25fOu7FhGRxOCHZsElRK6Pfi8wQoJ+7kMgjWDCzeJyfws1BzKCdds= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708679969; c=relaxed/simple; bh=Q0FbdRdB6nBI0aIGb393byRDit6/AWIKztZb74t9bD4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fXvrLDqDkxtY4rCGZp5VvrZs7O9I/INy6t0/3NZdDND/VOjIXUNMzsG+vYPRo5VLRjrc+JW5/P+Y+Pb+Ll9MdXpv6S3UZNKiT07naw112HI6CCoksYr32+MvqpOyn94KfUkBqhq2jsO8dSPmwSXZQApeYEFBER9wxSLyNvjxtao= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de; spf=pass smtp.mailfrom=alpha.franken.de; arc=none smtp.client-ip=193.175.24.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alpha.franken.de Received: from uucp by elvis.franken.de with local-rmail (Exim 3.36 #1) id 1rdRi6-0003JD-00; Fri, 23 Feb 2024 10:19:14 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id E58CCC0267; Fri, 23 Feb 2024 10:18:24 +0100 (CET) Date: Fri, 23 Feb 2024 10:18:24 +0100 From: Thomas Bogendoerfer To: Serge Semin Cc: Greg Kroah-Hartman , Jiri Slaby , Arnd Bergmann , Jiaxun Yang , Alexey Malahov , Stephen Rothwell , Andrew Morton , linux-mips@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] mips: zboot: Fix "no previous prototype" build warning Message-ID: References: <20240215171740.14550-1-fancer.lancer@gmail.com> <20240215171740.14550-4-fancer.lancer@gmail.com> Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240215171740.14550-4-fancer.lancer@gmail.com> On Thu, Feb 15, 2024 at 08:17:28PM +0300, Serge Semin wrote: > Without having the putc() prototype forwardly declared the next > build-warning is printed: > > arch/mips/boot/compressed/uart-prom.c:6:6: warning: no previous prototype for ‘putc’ [-Wmissing-prototypes] > ... > > Fix that by adding the "decompress.h" header file with the putc() function > declaration to the source files which have the method redefined. > > Signed-off-by: Serge Semin > --- > arch/mips/boot/compressed/uart-16550.c | 2 ++ > arch/mips/boot/compressed/uart-alchemy.c | 2 ++ > arch/mips/boot/compressed/uart-prom.c | 2 ++ > 3 files changed, 6 insertions(+) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]