From: Andy Shevchenko <andy@kernel.org>
To: Konstantin Pugin <rilian.la.te@ya.ru>
Cc: krzk@kernel.org, conor@kernel.org, lkp@intel.com, vz@mleia.com,
robh@kernel.org, jcmvbkbc@gmail.com, nicolas.ferre@microchip.com,
manikanta.guntupalli@amd.com, corbet@lwn.net,
ychuang3@nuvoton.com, u.kleine-koenig@pengutronix.de,
Maarten.Brock@sttls.nl,
"Konstantin Pugin" <ria.freelander@gmail.com>,
"Hugo Villeneuve" <hvilleneuve@dimonoff.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Lech Perczak" <lech.perczak@camlingroup.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v9 1/3] serial: sc16is7xx: announce support of SER_RS485_RTS_ON_SEND
Date: Fri, 26 Apr 2024 17:32:46 +0300 [thread overview]
Message-ID: <Ziu7DpoHGLrURI_9@smile.fi.intel.com> (raw)
In-Reply-To: <20240425183251.174412-2-rilian.la.te@ya.ru>
On Thu, Apr 25, 2024 at 09:32:33PM +0300, Konstantin Pugin wrote:
> From: Konstantin Pugin <ria.freelander@gmail.com>
>
> When specifying flag SER_RS485_RTS_ON_SEND in RS485 configuration,
> we get the following warning after commit 4afeced55baa ("serial: core:
> fix sanitizing check for RTS settings"):
>
> invalid RTS setting, using RTS_AFTER_SEND instead
>
> This results in SER_RS485_RTS_AFTER_SEND being set and the
> driver always write to the register field SC16IS7XX_EFCR_RTS_INVERT_BIT,
> which breaks some hardware using these chips.
>
> The hardware supports both RTS_ON_SEND and RTS_AFTER_SEND modes, so fix
> this by announcing support for RTS_ON_SEND.
Greg KH, who is maintainer of TTY/serial subsystem, usually asks to separate
fixes from new features. So, sending this patch separately may not only help
him, but let's move forward with your stuff.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-04-26 14:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 18:32 [PATCH v9 0/3] add support for EXAR XR20M1172 UART Konstantin Pugin
2024-04-25 18:32 ` [PATCH v9 1/3] serial: sc16is7xx: announce support of SER_RS485_RTS_ON_SEND Konstantin Pugin
2024-04-26 14:32 ` Andy Shevchenko [this message]
2024-04-26 15:02 ` Konstantin P.
2024-04-26 15:06 ` Andy Shevchenko
2024-04-26 15:10 ` Andy Shevchenko
2024-04-25 18:32 ` [PATCH v9 2/3] dt-bindings: sc16is7xx: Add compatible line for XR20M1172 UART Konstantin Pugin
2024-04-25 18:32 ` [PATCH v9 3/3] serial: sc16is7xx: add support for EXAR " Konstantin Pugin
2024-04-25 21:19 ` Hugo Villeneuve
2024-04-26 6:58 ` Konstantin P.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ziu7DpoHGLrURI_9@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=Maarten.Brock@sttls.nl \
--cc=conor@kernel.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=hvilleneuve@dimonoff.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jcmvbkbc@gmail.com \
--cc=jirislaby@kernel.org \
--cc=krzk@kernel.org \
--cc=lech.perczak@camlingroup.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkp@intel.com \
--cc=manikanta.guntupalli@amd.com \
--cc=nicolas.ferre@microchip.com \
--cc=ria.freelander@gmail.com \
--cc=rilian.la.te@ya.ru \
--cc=robh@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vz@mleia.com \
--cc=ychuang3@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox