From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: lumingyindetect@126.com
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
ilpo.jarvinen@linux.intel.com, gregkh@linuxfoundation.org,
jirislaby@kernel.or
Subject: Re: [PATCH] serial: 8250_lpss: Fix memory leak in lpss8250_probe()
Date: Fri, 26 Apr 2024 17:44:14 +0300 [thread overview]
Message-ID: <Ziu9viefEtkQmHbz@smile.fi.intel.com> (raw)
In-Reply-To: <20240426133959.1294012-1-lumingyindetect@126.com>
On Fri, Apr 26, 2024 at 02:39:59PM +0100, lumingyindetect@126.com wrote:
> From: LuMingYin <lumingyindetect@126.com>
>
> The return statements at line 347 and line 351 in the lpss8250_probe()
> function result in a memory leak of the variable pdev. Add a label named
> free_irq_vectors in the lpss8250_probe() function to release the memory area
> pointed to by pdev. Modify the two return statements mentioned above to jump
> to the label "free_irq_vectors" instead.
> Fixes: e88c4cfcb7b888ac374916806f86c17d8ecaeb67 ("serial: 8250_lpss: fix memory in lpss8250_probe()")
Same as for the previous version, NAK.
This patch does NOT fix anything. Please, read the code and try to understand
how it works.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-04-26 14:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 13:39 [PATCH] serial: 8250_lpss: Fix memory leak in lpss8250_probe() lumingyindetect
2024-04-26 13:48 ` Ilpo Järvinen
2024-04-26 13:55 ` Greg KH
2024-04-26 14:44 ` Andy Shevchenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-04-26 11:47 lumingyindetect
2024-04-26 12:28 ` Markus Elfring
2024-04-26 13:01 ` lumingyindetect
2024-04-26 15:07 ` Christian Heusel
2024-04-26 13:45 ` Ilpo Järvinen
2024-04-26 13:53 ` Dan Carpenter
2024-04-26 14:45 ` Andy Shevchenko
2024-04-26 15:32 ` Dan Carpenter
2024-04-26 15:37 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ziu9viefEtkQmHbz@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.or \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lumingyindetect@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).