Re: [PATCH 3/6] tty: mxser: serial: 8250: Relocate device IDs from mxser to 8250_pci

Crescent CY Hsieh
2024-06-13T10:03:10Z

On Tue, Jun 11, 2024 at 09:42:36AM +0200, Jiri Slaby wrote:
> On 07. 06. 24, 13:43, Crescent Hsieh wrote:
> > @@ -212,32 +187,7 @@ static const struct {
> > /* driver_data correspond to the lines in the structure above
> > see also ISA probe function before you change something */
> > static const struct pci_device_id mxser_pcibrds[] = {
> > - { PCI_DEVICE_DATA(MOXA, C168, 8) },
> > - { PCI_DEVICE_DATA(MOXA, C104, 4) },
> > - { PCI_DEVICE_DATA(MOXA, CP132, 2) },
> > - { PCI_DEVICE_DATA(MOXA, CP114, 4) },
> > - { PCI_DEVICE_DATA(MOXA, CT114, 4) },
> > - { PCI_DEVICE_DATA(MOXA, CP102, 2 | MXSER_HIGHBAUD) },
>
> How is this MXSER_HIGHBAUD handled in 8250_pci?

I will first create a patch to split the Moxa-related code from
`8250_pci.c` into `8250_moxa.c`. Then, I will try to migrate `mxser.c`
to `8250_moxa.c` and handle MXSER_HIGHBAUD there.

>
> > - { PCI_DEVICE_DATA(MOXA, CP104U, 4) },
> > - { PCI_DEVICE_DATA(MOXA, CP168U, 8) },
> > - { PCI_DEVICE_DATA(MOXA, CP132U, 2) },
> > - { PCI_DEVICE_DATA(MOXA, CP134U, 4) },
> > - { PCI_DEVICE_DATA(MOXA, CP104JU, 4) },
> > { PCI_DEVICE_DATA(MOXA, RC7000, 8) }, /* RC7000 */
>
> Can you simply add this exception to mxser_get_nports() I suggested in 1/6
> and drop the whole mxser then \o/?
>
> I had a long-term plan to mount mxser onto serial-core (or 8250). I haven't
> managed the conversion yet. So I am glad to see this.

Yes, I know you have been working hard to convert `mxser.c` into a
general driver, and I truly appreciate your efforts.
https://lore.kernel.org/linux-serial/20210618061516.662-1-jslaby@suse.cz/

However, I am curious if a general serial driver can support the full
functionality of PCI serial boards. Additionally, what's the plans for
addressing specific functionalities?

---
Sincerely,
Crescent Hsieh