From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C95B3838A for ; Fri, 21 Jun 2024 12:15:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718972124; cv=none; b=KdjtMLF3hvhlicZHkcMm/4Pl/DOTIls2scjYrQi8PxchrQPdjAFgDP+WMu5jRPt6INKCagDQ5GPY0lMJt1hgJz5fjJIO0Zjpn7yD+xtbe4FbOvpiHuorRmSYDoUSCeBXpmp1Sheyp2+614B+aTuKKHAByKI7WiHMpt4jX79Qr/g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718972124; c=relaxed/simple; bh=Ul4UPYH/+TY+vUx++IuWcHjMYpRIIfVR+t0N7A/0g94=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dbQrH8VYwrb2GVA4ZKyEguz7hSnOm7NgOZkmtxc2E8PKysdlawFjP93AK4TcthHb9SC9b2j2GzHpvOMhhXfN9LpeD48WRkOiMZ9iBsx12O/mbWdi6q3OHcFVrZ7MUo0uZ3zFeEejvJqd4BZLGqpgaP+RDnN9IpvwfAmJe1j+9B0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=br6XBrqI; arc=none smtp.client-ip=209.85.208.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="br6XBrqI" Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2eaae2a6dc1so36797451fa.0 for ; Fri, 21 Jun 2024 05:15:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1718972119; x=1719576919; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6xH4TjJ1vLeO7hvhqxB1jVAlRByyOLroRcKk1YzxwLQ=; b=br6XBrqIgFKrlXfFCWa2cyRVqNBbxtwrzvbhZV77Z35bkJ+YKAfa1UVKxThHs64KR1 9CplcFrFXuDWqr9a4OLgzEM3cdMG2ougs9IcO2kpj4WFYDyC+QqTK0DesC8RV5yw3/7v Tmtf6xcS2IUWLsrPVornHpkRb4zjwdtFprb2vbmAQxzJ97rHrbOaxR2YmrLLAro9NWJ4 CgEqspfaUx71anH5H6mtVSJ0oAdDZ02kOgUY46PBJT2CNOG7guU37g+3r8xHM+nLv/Ut HO9J48O6qMuzoK8yFxMdK1UphQIeHikgWgMwURtZVa3dJ+A0KoXQ1MtKjdL/KZ6502Qw 6/gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718972119; x=1719576919; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6xH4TjJ1vLeO7hvhqxB1jVAlRByyOLroRcKk1YzxwLQ=; b=MXvc1iqp+Dpsq9fFQ9UCklBFVY7+xDxpG0wHKkH78tnUdFJQ8LI/yaK+DsULeZlycE h+Mg3astoQVNZPjTg9hRWeVndJSLt3Ft2td3ZhA4iFXXp7/dhjf5mzsZWAV3mulhW5UQ Ojj4Ufk+axPDE05PlPmiUql107Ql/EDyQ8FKT0ESeXafP4kFx/SCb5WwiH+6FBqJDY8D dpn2Stzr2Xf2BXQkbed/pcesHcbImsjcPNckCH19qEbhoGxTQLKKEnqfccDGbhEaSFZv KrfJy7V/UMzsqwOwDZlQTBXtQLzklKaMxuhFkdZL7kJ5uUNVCNKVBvYRRN1AMWcHN3hm MMVQ== X-Forwarded-Encrypted: i=1; AJvYcCVuGYzzuQcEFGNJB9LK3ra/oSDVDNgKX5laTs1lPk0kgn9zmfGSw/PpJ8UOC2+16NSWpACLzgZ57sUteOTt+Qwq6D04kHqUiFK+05gw X-Gm-Message-State: AOJu0Yyv4pBLu7lAwjs28zIyU68iD9Mj+7KGOjvC5/NP0DfZKq9fY8qg EVwAfVaOTlKF/zjT4ebmXdKu1Y6L0b1YI2iUsQhKY0rvJMkWtfPYS+r7W3s+lVw= X-Google-Smtp-Source: AGHT+IGTk3TufthfvrmTzsIzthh/R+FGLBg4ydeD9dSFSJdwe3KkpatXVXYn3/PLrKsUx4xzR+4XkQ== X-Received: by 2002:a2e:7c10:0:b0:2ea:e1fe:2059 with SMTP id 38308e7fff4ca-2ec3ced180emr63245121fa.27.1718972119493; Fri, 21 Jun 2024 05:15:19 -0700 (PDT) Received: from pathway.suse.cz ([176.114.240.50]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f9eb321c24sm12834335ad.97.2024.06.21.05.15.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jun 2024 05:15:18 -0700 (PDT) Date: Fri, 21 Jun 2024 14:15:09 +0200 From: Petr Mladek To: Tony Lindgren Cc: Greg Kroah-Hartman , Jiri Slaby , Steven Rostedt , John Ogness , Sergey Senozhatsky , Tony Lindgren , Andy Shevchenko , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 3/4] serial: core: Revert unusable console quirk handling Message-ID: References: <20240620124541.164931-1-tony.lindgren@linux.intel.com> <20240620124541.164931-4-tony.lindgren@linux.intel.com> Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240620124541.164931-4-tony.lindgren@linux.intel.com> On Thu 2024-06-20 15:45:28, Tony Lindgren wrote: > There is no point of trying to handle the console quirks in the serial > core instead of console_setup() currently. > > With the console_setup() related changes, we are now deferring the > DEVNAME:0.0 style consoles based on the ":" naming only. So the serial > core console quirk handling would not do anything for the "ttyS" named > consoles as they are not deferred. > > Also the earlier approach would have depended on further changes to be > able to drop the serial port quirk handling from console_setup(). > > Let's revert the following console quirk handling related serial core > commits: > > b20172ca6bf4 ("serial: core: Fix ifdef for serial base console functions") > 4547cd76f08a ("serial: 8250: Fix add preferred console for serial8250_isa_init_ports()") > a8b04cfe7dad ("serial: 8250: Add preferred console in serial8250_isa_init_ports()") > a0f32e2dd998 ("serial: core: Handle serial console options") > 787a1cabac01 ("serial: core: Add support for DEVNAME:0.0 style naming for kernel console") > > Once the console quirk handling is gone, we add back the DEVNAME:0.0 > functionality with a minimal patch. > > Suggested-by: Petr Mladek > Link: https://lore.kernel.org/linux-serial/ZnGQ8JAu2OQf0GX8@pathway.suse.cz/ > Signed-off-by: Tony Lindgren Reviewed-by: Petr Mladek Best Regards, Petr