From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 738C71C9DEC for ; Wed, 7 Aug 2024 09:23:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723022630; cv=none; b=JLmRpBEtW3Xd82VO5yaB2BhrI3dIp5HnECjyogXjIyTaut/KtNpLFYqJ1hnyL7dJU1JExBomnQAxk6uai3mQ8NW1js9qNQ8HWRhgz+WyUOCXpesbKpkoE67frxxjgIk6SGnrljHFPzozKWgNwWLQp1SMxYmyxzE4RFV8jYtq6cA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723022630; c=relaxed/simple; bh=l5Mj/BasNGyIDd8XRpsbwqmxFm681e6x+uIFItW6sOI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Wg1jGL2WOHN6CfJsj0TUkyQI18b7JeHPz4ARNguawrQ6NGlX4tY8mtr3Qn57WMboRNad9O9tom/2RE0OhINBaabXcSlMjUjDo6i97oVZ9by3F6IZigNaTBZtH50TtrGn9KKxZ8hMvSVYZNzH/NSxYVdQPiMeYAsjDiAy8P9VO5w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=gSTdqmA8; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="gSTdqmA8" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1fd640a6454so13574865ad.3 for ; Wed, 07 Aug 2024 02:23:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1723022629; x=1723627429; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0W3ELwTgJqrVr9YXSIirH10n9Jhjm2A/ho7Bv2qO5pI=; b=gSTdqmA8y2pfuGf2cFpw+4G/tuw1+be6E7TnnfZPfQ5l/fxa5Pei9mDIsGZjfNcbVm 25MvP67eeqSVYiiacJYFDanSNSJ7QTTEu3pyjcE5i+t9Iw4KCn5ZrXzxNaWq4yITGp3F V2DR0Q5ukWgr7CceieDrIWiLknMzYAkmnw1uyMkuTvq8AjHbqDHgCYINZ7QDOenIbVNc mKoo0Lc/rFWjHxnYLttu/1dqt84qIC1Cx/Rvh/zyGRv8imtqaqZnXDHft+aRruLNgnQs KY9VPH4S0s5VEpHEhu+8u5WBmbwcsao0o5+XNeWniWULBaGXvxRsk/tWEY6oD6u5vCfL ugWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723022629; x=1723627429; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0W3ELwTgJqrVr9YXSIirH10n9Jhjm2A/ho7Bv2qO5pI=; b=THBS665/pOjiC++ZF1EI5PU70VJSNjwKl4iyc+EbcXmtL2XgoKSZ5+BggvuktWpWzI Ed0cQC5NggdN49YvbOMIXlb2cNhvAFyEI8yBuyjykxArAusKrAF6gDY2DgpSTCjRiOY+ 2Vij3PLfISOgV1IqmwBEJ566VbstjH1QAs/F4fIPAgLqSr9dFWtfyITBABMGodCxA6aS qUpai5P/OYfzwtNGk3c4yPnGVsBmfMLU93brCjgY++qhSZbNBuk/M+JTwKvI5q+J9/kB EHvRP1OYz69W4gp7+SY7ohPNDRMRbpDE7y4mQMvJBRg8FlK0Ks580tN0mVcQdMabe76c EX7Q== X-Forwarded-Encrypted: i=1; AJvYcCVJ1xri/rrgNVyQT+z+Q9LTuApgIgy+/lxLwloil10zvnjc9xAhFzOsiDCN5FZKcxRoMtuYAF8WvkCHJil804N/iPLWF6yfzmj7N+Ok X-Gm-Message-State: AOJu0YwvPwOdNn61GGcCi8X03m27QLuwIX3871fU7dgujwu9QOMn8Yk5 Mtn+axrhtELqrO5gYTUNJrctMW40kJzzm4RPO3D0QchGJXOZsiSfm3veKaEsqbg= X-Google-Smtp-Source: AGHT+IH+LveGfKWKMUa68Hj8gRwcrWvlHYa2Pnf6BOphdfXnSgszfHvPeUra7j0FqX/u6iQlXjUmSg== X-Received: by 2002:a17:903:1247:b0:1f9:f018:6973 with SMTP id d9443c01a7336-1ff574a1e32mr185937235ad.51.1723022628595; Wed, 07 Aug 2024 02:23:48 -0700 (PDT) Received: from sunil-laptop ([106.51.198.16]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ff58f2734dsm102294715ad.41.2024.08.07.02.23.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Aug 2024 02:23:48 -0700 (PDT) Date: Wed, 7 Aug 2024 14:53:42 +0530 From: Sunil V L To: Arnd Bergmann Cc: Greg Kroah-Hartman , Jiri Slaby , Arnd Bergmann , Andy Shevchenko , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH 2/2] serial: 8250_platform: fix uart_8250_port initializer Message-ID: References: <20240807075751.2206508-1-arnd@kernel.org> <20240807075751.2206508-2-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240807075751.2206508-2-arnd@kernel.org> Hi Arnd, On Wed, Aug 07, 2024 at 09:57:44AM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > The first element in uart_8250_port is a structure, so initializing > it to 0 causes a warning on newer compilers: > > drivers/tty/serial/8250/8250_platform.c: In function 'serial8250_platform_probe': > drivers/tty/serial/8250/8250_platform.c:111:40: error: excess elements in struct initializer [-Werror] > 111 | struct uart_8250_port uart = { 0 }; > > Use the modern empty {} initializer instead that works on all > supported compilers. > > Fixes: d9e5a0ce2f16 ("serial: 8250_platform: Enable generic 16550A platform devices") > Signed-off-by: Arnd Bergmann > --- > drivers/tty/serial/8250/8250_platform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/8250/8250_platform.c b/drivers/tty/serial/8250/8250_platform.c > index c9ef988d58b3..2a3765334843 100644 > --- a/drivers/tty/serial/8250/8250_platform.c > +++ b/drivers/tty/serial/8250/8250_platform.c > @@ -108,7 +108,7 @@ void __init serial8250_isa_init_ports(void) > static int serial8250_platform_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > - struct uart_8250_port uart = { 0 }; > + struct uart_8250_port uart = { }; Thanks! I was not sure about this. So, I sent a patch to use memset just couple of hours ago. I sent different fix for other ACPI_PTR issue as well. But I think your fixes are better. Reviewed-by: Sunil V L Thanks! Sunil