From: Sunil V L <sunilvl@ventanamicro.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 1/2] serial: 8250_platform: remove ACPI_PTR() annotation
Date: Wed, 7 Aug 2024 14:54:25 +0530 [thread overview]
Message-ID: <ZrM9SRgRLYXIL8B1@sunil-laptop> (raw)
In-Reply-To: <20240807075751.2206508-1-arnd@kernel.org>
On Wed, Aug 07, 2024 at 09:57:43AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The acpi_platform_serial_table[] array is defined globally without
> an #ifdef check for CONFIG_ACPI, so ACPI_PTR() makes no sense
> here:
>
> drivers/tty/serial/8250/8250_platform.c:271:36: error: 'acpi_platform_serial_table' defined but not used [-Werror=unused-const-variable=]
> 271 | static const struct acpi_device_id acpi_platform_serial_table[] = {
>
> Fixes: d9e5a0ce2f16 ("serial: 8250_platform: Enable generic 16550A platform devices")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/tty/serial/8250/8250_platform.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_platform.c b/drivers/tty/serial/8250/8250_platform.c
> index 306b488aa996..c9ef988d58b3 100644
> --- a/drivers/tty/serial/8250/8250_platform.c
> +++ b/drivers/tty/serial/8250/8250_platform.c
> @@ -281,7 +281,7 @@ static struct platform_driver serial8250_isa_driver = {
> .resume = serial8250_resume,
> .driver = {
> .name = "serial8250",
> - .acpi_match_table = ACPI_PTR(acpi_platform_serial_table),
> + .acpi_match_table = acpi_platform_serial_table,
Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
Thanks!
Sunil
next prev parent reply other threads:[~2024-08-07 9:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 7:57 [PATCH 1/2] serial: 8250_platform: remove ACPI_PTR() annotation Arnd Bergmann
2024-08-07 7:57 ` [PATCH 2/2] serial: 8250_platform: fix uart_8250_port initializer Arnd Bergmann
2024-08-07 9:23 ` Sunil V L
2024-08-08 14:12 ` Andy Shevchenko
2024-08-09 9:19 ` Ilpo Järvinen
2024-08-07 9:24 ` Sunil V L [this message]
2024-08-08 14:12 ` [PATCH 1/2] serial: 8250_platform: remove ACPI_PTR() annotation Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrM9SRgRLYXIL8B1@sunil-laptop \
--to=sunilvl@ventanamicro.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).