From: Andy Shevchenko <andy@kernel.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: "Lech Perczak" <lech.perczak@camlingroup.com>,
linux-serial@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Hugo Villeneuve" <hvilleneuve@dimonoff.com>,
"Krzysztof Drobiński" <k.drobinski@camlintechnologies.com>,
"Pawel Lenkow" <p.lenkow@camlintechnologies.com>,
"Kirill Yatsenko" <kirill.yatsenko@camlingroup.com>
Subject: Re: [PATCH v2 3/3] serial: sc16is7xx: convert bitmask definitions to use BIT macro
Date: Tue, 13 Aug 2024 16:06:14 +0300 [thread overview]
Message-ID: <ZrtaRjoa3MpOeQR9@smile.fi.intel.com> (raw)
In-Reply-To: <231efd2f-e402-06f9-d193-192065c5298d@linux.intel.com>
On Tue, Aug 13, 2024 at 11:30:57AM +0300, Ilpo Järvinen wrote:
> On Mon, 12 Aug 2024, Andy Shevchenko wrote:
> > On Mon, Aug 12, 2024 at 06:56:53PM +0200, Lech Perczak wrote:
...
> > > #define SC16IS7XX_IIR_ID_MASK 0x3e /* Mask for the interrupt ID */
> >
> > While at it, why not convert the MASK(s) to use GENMASK()?
> > It's logically coupled change, no need to have a separate patch.
...
> > > #define SC16IS7XX_LSR_BRK_ERROR_MASK 0x1E /* BI, FE, PE, OE bits */
> >
> > Ditto.
>
> No. This is not GENMASK() but combination of other bits. This mask define
> should be a combination those bit defines and the comment dropped because
> it adds no value after using the bit defines directly.
I agree with you on this. I'm pretty fine with either approach.
> > (maybe more that are not visible in the context of this patch)
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-08-13 13:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 16:53 [PATCH v2 0/3] serial: sc16is7xx: cosmetic cleanup Lech Perczak
2024-08-12 16:54 ` [PATCH v2 1/3] serial: sc16is7xx: remove SC16IS7XX_MSR_DELTA_MASK Lech Perczak
2024-08-12 17:09 ` Andy Shevchenko
2024-08-12 16:56 ` [PATCH v2 2/3] serial: sc16is7xx: fix copy-paste errors in EFR_SWFLOWx_BIT macros Lech Perczak
2024-08-12 17:08 ` Andy Shevchenko
2024-08-12 16:56 ` [PATCH v2 3/3] serial: sc16is7xx: convert bitmask definitions to use BIT macro Lech Perczak
2024-08-12 17:08 ` Andy Shevchenko
2024-08-13 8:30 ` Ilpo Järvinen
2024-08-13 13:06 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrtaRjoa3MpOeQR9@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hvilleneuve@dimonoff.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=k.drobinski@camlintechnologies.com \
--cc=kirill.yatsenko@camlingroup.com \
--cc=lech.perczak@camlingroup.com \
--cc=linux-serial@vger.kernel.org \
--cc=p.lenkow@camlintechnologies.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox