From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Parker Newman <parker@finest.io>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Parker Newman <pnewman@connecttech.com>
Subject: Re: [PATCH v2 3/4] serial: 8250_exar: Replace custom EEPROM read with eeprom_93cx6
Date: Fri, 20 Sep 2024 18:26:08 +0300 [thread overview]
Message-ID: <Zu2UEAY1jweup6tS@smile.fi.intel.com> (raw)
In-Reply-To: <87719d2113970b6ff4979329fb96346a0aca9775.1726838531.git.pnewman@connecttech.com>
On Fri, Sep 20, 2024 at 10:03:23AM -0400, Parker Newman wrote:
> From: Parker Newman <pnewman@connecttech.com>
...
> + osc_freq = le16_to_cpu(ee_words[0]) | (le16_to_cpu(ee_words[1]) << 16);
> + if (osc_freq == GENMASK(31, 0))
> return -EIO;
Just noticed that you have
#define CTI_EE_MASK_OSC_FREQ_LOWER GENMASK(15, 0)
#define CTI_EE_MASK_OSC_FREQ_UPPER GENMASK(31, 16)
So, please modify them and the above check using these.
Something like
#define CTI_EE_MASK_OSC_FREQ GENMASK(31, 0)
osc_freq = le16_to_cpu(ee_words[0]) | (le16_to_cpu(ee_words[1]) << 16);
if (osc_freq == CTI_EE_MASK_OSC_FREQ)
return -EIO;
P.S> If I am not mistaken the definitions were only used in this function.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-09-20 15:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 14:03 [PATCH v2 0/4] serial: 8250_exar: Replace custom EEPROM code with eeprom_93cx6 Parker Newman
2024-09-20 14:03 ` [PATCH v2 1/4] misc: eeprom: eeprom_93cx6: Add quirk for extra read clock cycle Parker Newman
2024-09-20 14:45 ` Andy Shevchenko
2024-09-20 15:03 ` Parker Newman
2024-09-20 14:48 ` Andy Shevchenko
2024-09-20 14:03 ` [PATCH v2 2/4] misc: eeprom: eeprom_93cx6: Switch to BIT() macro Parker Newman
2024-09-20 14:46 ` Andy Shevchenko
2024-09-20 14:03 ` [PATCH v2 3/4] serial: 8250_exar: Replace custom EEPROM read with eeprom_93cx6 Parker Newman
2024-09-20 14:55 ` Andy Shevchenko
2024-09-20 15:09 ` Parker Newman
2024-09-20 15:26 ` Andy Shevchenko [this message]
2024-09-20 15:42 ` Parker Newman
2024-09-20 15:46 ` Andy Shevchenko
2024-09-20 14:03 ` [PATCH v2 4/4] serial: 8250_exar: Remove old exar_ee_read() and other unneeded code Parker Newman
2024-09-20 14:37 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zu2UEAY1jweup6tS@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=parker@finest.io \
--cc=pnewman@connecttech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).