From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Parker Newman <parker@finest.io>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Parker Newman <pnewman@connecttech.com>
Subject: Re: [PATCH v1 2/6] misc: eeprom: eeprom_93cx6: Switch to BIT() macro
Date: Fri, 13 Sep 2024 20:48:45 +0300 [thread overview]
Message-ID: <ZuR6_aPZdB80Kb77@smile.fi.intel.com> (raw)
In-Reply-To: <ef318e16db5c0743c792950d0f2504d80b52a106.1726237379.git.pnewman@connecttech.com>
On Fri, Sep 13, 2024 at 10:55:39AM -0400, Parker Newman wrote:
> From: Parker Newman <pnewman@connecttech.com>
>
> Use the BIT() macro rather than (1 << (i - 1))
Missed period at the end.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-09-13 17:48 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 14:55 [PATCH v1 0/6] serial: 8250_exar: Replace custom EEPROM code with eeprom_93cx6 Parker Newman
2024-09-13 14:55 ` [PATCH v1 1/6] misc: eeprom: eeprom_93cx6: Add quirk for extra read clock cycle Parker Newman
2024-09-13 17:48 ` Andy Shevchenko
2024-09-13 18:24 ` Parker Newman
2024-09-13 18:32 ` Andy Shevchenko
2024-09-13 14:55 ` [PATCH v1 2/6] misc: eeprom: eeprom_93cx6: Switch to BIT() macro Parker Newman
2024-09-13 17:48 ` Andy Shevchenko [this message]
2024-09-13 14:55 ` [PATCH v1 3/6] misc: eeprom: eeprom_93cx6: Replace printk(KERN_ERR ...) with pr_err() Parker Newman
2024-09-13 17:54 ` Andy Shevchenko
2024-09-13 19:12 ` Parker Newman
2024-09-13 19:26 ` Andy Shevchenko
2024-09-14 18:58 ` Greg Kroah-Hartman
2024-09-16 9:55 ` Andy Shevchenko
2024-09-16 10:25 ` Greg Kroah-Hartman
2024-09-16 10:32 ` Andy Shevchenko
2024-09-16 12:04 ` Parker Newman
2024-09-16 12:18 ` Andy Shevchenko
2024-09-16 15:20 ` Parker Newman
2024-09-16 15:27 ` Andy Shevchenko
2024-09-13 14:55 ` [PATCH v1 4/6] serial: 8250_exar: Replace custom EEPROM read with eeprom_93cx6 Parker Newman
2024-09-13 18:06 ` Andy Shevchenko
2024-09-14 13:26 ` kernel test robot
2024-09-16 10:09 ` Andy Shevchenko
2024-09-13 14:55 ` [PATCH v1 5/6] serial: 8250_exar: Remove old exar_ee_read() and other unneeded code Parker Newman
2024-09-13 18:07 ` Andy Shevchenko
2024-09-13 14:55 ` [PATCH v1 6/6] serial: 8250_exar: Add select EEPROM_93CX6 in Kconfig Parker Newman
2024-09-13 18:08 ` Andy Shevchenko
2024-09-13 18:10 ` [PATCH v1 0/6] serial: 8250_exar: Replace custom EEPROM code with eeprom_93cx6 Andy Shevchenko
2024-09-13 18:50 ` Parker Newman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuR6_aPZdB80Kb77@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=parker@finest.io \
--cc=pnewman@connecttech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).