From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C10319DF4C for ; Thu, 19 Sep 2024 12:57:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726750676; cv=none; b=AYc7R+4D+NIpzUGvyDe4/UQ9iZmxDivqCIaVj3ejphQ+q45Kvt5oaxJn+qTQ7zf6urQg7sxm73YBx81rSoAKpQVFTksCtJ3lFk+uQlsb2FkYeP0wew9t1UTfrEvDSZ9QZ5/rHaTzK6TTd/se9P5ExPxbyla9bWvjTCjQ33LG2NQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726750676; c=relaxed/simple; bh=76ELJO2trC1AW62eOoSKaxfwlQZw6rut1Tua7Zv1+cQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=POCkahjKEbLUNTN64vh+KF0L2G4s0ntRdpAamhXpVAA+Da0E5ftg32rGgVb7NOEOwxEAAEY8f6QE7+sQS9ZtNqxkvAwu/tRGcXU7pMsx5EKcIEfTc9UPNiX9+EhBr5bIyFWsKfyY1Dc4gOHwrwdbrx6kmLf2jiUmcr7KoC1f0TM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Hq6aECeD; arc=none smtp.client-ip=209.85.208.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Hq6aECeD" Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2f762de00e5so8962141fa.3 for ; Thu, 19 Sep 2024 05:57:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1726750672; x=1727355472; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fpL5nrSfWFIRQTaDmvo3b1v9flOhJaDZgUF3bcUIUyc=; b=Hq6aECeDvaTnhEO3mmxdMBndV33kFS9r3tIOjTPHKJhYr8F5fkIr+Mq6pQrzKyla2z EHruX7MZthDo9INLHrVQt68rbnPBdFS4NatQvpLxdM6KjI3iFRuX3QheXxj+gju5WIxF j8pUQb34ZpsrZNZbZ7fYFzf11wgamM9+AdArUeQ55CgjkbHgATbYLKbnMEvYf5hSjIKr mUgy9OwKkd7xDDtD2c5UB3+V9tvKpka/49blNKvhFknQEvZpiMyMLgqr1zl+rX14X0vM O2PpJ0u/4q61UajfvVS3BADj3lHRxLuVrasJHI3r6OgaZwahYWq4pySaDtFif7RmtKVA EjPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726750672; x=1727355472; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fpL5nrSfWFIRQTaDmvo3b1v9flOhJaDZgUF3bcUIUyc=; b=Bc3VG0H5gHzyyT2r0xnF73lIUNxYMcc41NbF/7+is0666mfPS7yEUKdQ/1sI0GGwBG hfurbNWOw4KDZwqUrW8fmzqHvXRJt57SARhHzQ6sHxyB/3RaLyoYVyXmYpPafzdf2Xdg X7Sy10ORwHfCPCFR31K3XhYLzE/fNoEAa1nFKlVW3+LIbv0YHts+9nmOD05XDhMbJYUS n7xobW4vEPm9iKjDzghJaB3xG70I/LMoQ5jCUUVoSaSk2IeC6epDXsSOL8Le2o/yB9Us eutXyo+XoLOXBIV/3XyUAgfpVUE7ZdEpg0yi/F8IWNQJOY0eI+qgXYLgtiS6nRZUa392 8Gbw== X-Forwarded-Encrypted: i=1; AJvYcCV626d8gP1wvD2UKdtOYuefGg8NKFAASVh84MJWzvpXhpZPsnRAcnV73cW1U04MIhDAtZESP0bcHLJ1dTU=@vger.kernel.org X-Gm-Message-State: AOJu0YzFXD/mBv9McGwFs4WX9Ueqc02JKpWOWYm6JU+CTX2T0cHW++hN lE9d9DSDINfD40kmkz38qG67LaNDe09APtNrI6PzdwHWfY9xqPn2iuJiGlNtUQE= X-Google-Smtp-Source: AGHT+IG4h95qe6GKSksmnJpvKJM8XOEJO8HMQY3bFlHGG7ixgB+TFNte/YhFDrha1wGPiRsX+C3SXQ== X-Received: by 2002:a2e:bea6:0:b0:2ef:22ad:77b5 with SMTP id 38308e7fff4ca-2f787f447c9mr138932411fa.29.1726750671610; Thu, 19 Sep 2024 05:57:51 -0700 (PDT) Received: from pathway.suse.cz ([176.114.240.50]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20794601017sm79331225ad.85.2024.09.19.05.57.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Sep 2024 05:57:50 -0700 (PDT) Date: Thu, 19 Sep 2024 14:57:35 +0200 From: Petr Mladek To: Raul E Rangel Cc: linux-kernel@vger.kernel.org, Raul E Rangel , Andrew Morton , Christophe Leroy , Geert Uytterhoeven , Greg Kroah-Hartman , Huang Shijie , Ingo Molnar , Jiri Slaby , Luis Chamberlain , Masami Hiramatsu , Peter Zijlstra , Rasmus Villemoes , Yuntao Wang , linux-serial@vger.kernel.org Subject: Re: [PATCH v2] init: Don't proxy `console=` to earlycon Message-ID: References: <20240911123507.v2.1.Id08823b2f848237ae90ce5c5fa7e027e97c33ad3@changeid> Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240911123507.v2.1.Id08823b2f848237ae90ce5c5fa7e027e97c33ad3@changeid> On Wed 2024-09-11 12:35:14, Raul E Rangel wrote: > Today we are proxying the `console=` command line args to the > `param_setup_earlycon()` handler. This is done because the following are > equivalent: > > console=uart[8250],mmio,[,options] > earlycon=uart[8250],mmio,[,options] > > Both invocations enable an early `bootconsole`. `console=uartXXXX` is > just an alias for `earlycon=uartXXXX`. > > In addition, when `earlycon=` (empty value) or just `earlycon` > (no value) is specified on the command line, we enable the earlycon > `bootconsole` specified by the SPCR table or the DT. > > The problem arises when `console=` (empty value) is specified on the > command line. It's intention is to disable the `console`, but what > happens instead is that the SPRC/DT console gets enabled. > > This happens because we are proxying the `console=` (empty value) > parameter to the `earlycon` handler. The `earlycon` handler then sees > that the parameter value is empty, so it enables the SPCR/DT > `bootconsole`. > > This change makes it so that the `console` or `console=` parameters no > longer enable the SPCR/DT `bootconsole`. I also cleans up the hack in > `main.c` that would forward the `console` parameter to the `earlycon` > handler. > > Signed-off-by: Raul E Rangel It like this approach. It works well: Reviewed-by: Petr Mladek Tested-by: Petr Mladek I could take it via the printk tree for 6.13. From my POV, it is too late for 6.12. I am sorry I have been busy with the printk rework :-( I am going to wait few days for another eventual review or taker. Best Regards, Petr