From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Omer Faruk BULUT <m.omerfarukbulut@gmail.com>
Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org,
pmladek@suse.com, paulmck@kernel.org, john.ogness@linutronix.de,
tony@atomide.com, arnd@arndb.de, u.kleine-koenig@pengutronix.de,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 2/2] 8250_core.c : Global variable shouldn't be initialized to NULL
Date: Tue, 15 Oct 2024 14:34:33 +0300 [thread overview]
Message-ID: <Zw5TSaN9BGyNwrsT@smile.fi.intel.com> (raw)
In-Reply-To: <20241014180415.2365-1-m.omerfarukbulut@gmail.com>
On Mon, Oct 14, 2024 at 09:04:15PM +0300, Omer Faruk BULUT wrote:
> I check it with checkpatch. Then remove the NULL part.
checkpatch may be false positive. Please, add a better analysis
that it's fine to do a such cleanup. Note, this variable is _not_
static.
...
> -const struct uart_ops *univ8250_port_base_ops = NULL;
> +const struct uart_ops *univ8250_port_base_ops;
Is it guaranteed to be NULL for non-static variables? If so,
we want to know the details.
> struct uart_ops univ8250_port_ops;
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-10-15 11:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 18:04 [PATCH 2/2] 8250_core.c : Global variable shouldn't be initialized to NULL Omer Faruk BULUT
2024-10-15 11:34 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zw5TSaN9BGyNwrsT@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=m.omerfarukbulut@gmail.com \
--cc=paulmck@kernel.org \
--cc=pmladek@suse.com \
--cc=tony@atomide.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox