From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 405E5185E53 for ; Mon, 11 Nov 2024 13:37:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731332265; cv=none; b=cc8x9b2/jJMGs9Av1ChA1itnOXA7OUUGv/fw+4tZgqCuvFJjv1ibvpwiFEzLoagqzvkkhWokk3THpbPCc6FyTNkN5unvRwPvpmv59g7+omX/FjKScvpPk9EMaGMOYbLYHZ41P//2QM+92WfNpfFv5xVSXkzt4GXK3WVWjHymOOY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731332265; c=relaxed/simple; bh=zldQuZy7Vw8Jc/U9Gqrx5DoU6JGXukbJ4pnR6Ieqjxc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=h5q66jx800N5EC71bY8VM2vCxkoI+GP783L+km1f64DGQika3dT7hKvacab2myNgFCny9KOQhqBYYJhVqkNcS7ONssf9f0FiF2lPQR6U25xgTD6ylBUgUnNWXUJp2RswV8hab9M0ZhC8oUnG6jnExeORZJ1+ospCZL553oRUPD4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Bk5lvahY; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Bk5lvahY" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4315839a7c9so42878145e9.3 for ; Mon, 11 Nov 2024 05:37:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1731332262; x=1731937062; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=H3alwZykr3cxEiilJjH/3zMnNgVJKTf1Srqg5Us7D+k=; b=Bk5lvahYiGE4jL6tcHqoopyu1WfjPDKbyX9SCGrki38ITA/li6vQ4fSa17eLU+lIEI HDrsOhffM/DSoNIop0GykMihgHxucYtxYSCMHPNguohhSSp8co+Kk4SVaVwzEN0rSVQN SHY2N22Xf3167NC32mYBFscPBa48OzLZj63HaCbMkc6wSm4Ze82x+8gHLAwcpI04fqd0 h4xKHtRtjYxM4aQG42Cx+4hmCi8Qyn9KSg7UptIO76TJF0Vis95OM3QDqpLEOrrt7K8L OQMJPHmP0VzSIxicV5aWPRJ+Kd7LQMzXMVZA1WMmKPeLPmcoCJGegf0VYyyQJB2lDtt5 WNYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731332262; x=1731937062; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=H3alwZykr3cxEiilJjH/3zMnNgVJKTf1Srqg5Us7D+k=; b=qfL0Zde8TrPMgVI3YMI4ialu0mY6Uq8XR9BtZG+hAa1A3YE55TU2cjAMGeJ/zNdEGh JHcLCVHELw+h0aFV7VW3UQmBbj/hoqJTKIqk/rCfdFSKR0jWtaoD70myno/XOmu31nHz N0/a/O5Xj9pvu9ydm+SQSM30TVSV/aBtyi5Jnbrv1SM0YdQQmFK/UYGImBfnXGt6MfCV 4SPOc+NAnsSUHrKy4NP8tR1efLSZGdTOfZZDp6XCen/Stmgt01gizRNISWRe4vDLH6oO WHihx5uT6gSdXdEw3RqIcD00NV5GRDnVidJRt9jpT+Pc222KNsoxVsxN7L7/2cWPlLbe kvng== X-Forwarded-Encrypted: i=1; AJvYcCVSu9ew2miPIOfkKhC5gNTzJjuts5mvC243kpF9KOaBEwL/h9n/+cXyq5zix9Zb/eakvEuiDR5XdJkqPe4=@vger.kernel.org X-Gm-Message-State: AOJu0YwW4xn0AejC2QmkDUYjK3GS/u31QetmQ7vz2vTzt7nTG21dEYnV hQnisssWmXYYTV2bk49YQ8rte0hd7eGHFMBGaw+1l/lbv40Lh4GhONrpcuyas2w= X-Google-Smtp-Source: AGHT+IHN6VX3szu3asu+FTdSapdN3XKQswp3SlPLA1xm4qyKmZWBrqljtY+pMYxuZ/VQ0J6d4xUkSQ== X-Received: by 2002:a05:600c:8715:b0:431:93d8:e1a1 with SMTP id 5b1f17b1804b1-432b751bcc2mr103836265e9.27.1731332261641; Mon, 11 Nov 2024 05:37:41 -0800 (PST) Received: from pathway.suse.cz ([176.114.240.50]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432b054b3fesm173495965e9.17.2024.11.11.05.37.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Nov 2024 05:37:41 -0800 (PST) Date: Mon, 11 Nov 2024 14:37:38 +0100 From: Petr Mladek To: Marcos Paulo de Souza Cc: Steven Rostedt , John Ogness , Sergey Senozhatsky , Greg Kroah-Hartman , Jiri Slaby , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v2 0/2] printk: Add force_con printk flag to not suppress sysrq header msgs Message-ID: References: <20241105-printk-loud-con-v2-0-bd3ecdf7b0e4@suse.com> Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu 2024-11-07 16:57:40, Petr Mladek wrote: > On Tue 2024-11-05 16:45:07, Marcos Paulo de Souza wrote: > > Hello, > > > > This is the second version of the patchset. It now addresses comments > > from John and Petr, while also mentioning that the current work solves > > one issue on handle_sysrq when the printk messages are deferred. > > > > The original cover-letter in is the v1. > > > > Please review! > > > > Signed-off-by: Marcos Paulo de Souza > > --- > > Changes in v2: > > - Mentioned that it fixes a bug related to loglevel= dance (suggested by John) > > - Changed to loud_con to FORCE_CON (John, Petr) > > - Don't skip printk delay if FORCE_CON is specified (John) > > - Set FORCE_CON when LOG_CONT is handled (John) > > - Changed force_con from a per-CPU variable to a global variable because > > we can't disable migration on the callsites. (John, Petr) > > - Used is_printk_force_console() on boot_delay_msec(), since it's used > > when the message is stored, instead of setting is as an argument. > > - Link to v1: https://lore.kernel.org/r/20241016-printk-loud-con-v1-0-065e4dad6632@suse.com > > --- > > Marcos Paulo de Souza (2): > > printk: Introduce FORCE_CON flag > > tty: sysrq: Use printk_force_console context on __handle_sysrq > > The patchset looks ready for linux-next from my POV. I am going to > push it there tomorrow or on Monday unless anyone complains. > > There was some bike-shedding about the code style in the reviews. > But the proposals did not look like a big win. I think that it > is not worth a respin. JFYI, the patchset has been committed into printk/linux.git, branch for-6.13-force-console. Best Regards, Petr