From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7B7F1D6DC5 for ; Fri, 15 Nov 2024 17:57:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731693437; cv=none; b=sbrFYcnUnhEsQajXQVkrJBDz9s4HyBrKVAHd2pIk7C3BvkyZ8rzfyggddCWeARZ4UjLaTwSuWElL9zDHhsgg54M5D7bB96udooEbdRyRocpAK/SeNAPmmXB0JeCpPbwwMWFDoqfQeTYCw8sZPERsRX4umBQOzbyusIK8PXTSHqU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731693437; c=relaxed/simple; bh=tqUC4NRe2FsZbgMAFBDs225f2ppUqDIgLL2znENzBRw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GyaGuwv8b6wjweNNdjIfGr9bLKIHX4UnBRtcv8fIKr9fo2ElMZ0zDyv8FqqPoEkZfpROyurwhLbf+8vFg0ut85xc22Mz4s9Hg2SozIVbXlIcRcfKKK5r9Wu8JpjlLo9qo44k76SU0DSPDcx7f0RKzqkRhniFp9V8o8nRe0ciAF4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=osandov.com; spf=none smtp.mailfrom=osandov.com; dkim=pass (2048-bit key) header.d=osandov-com.20230601.gappssmtp.com header.i=@osandov-com.20230601.gappssmtp.com header.b=T/rdvJQU; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=osandov.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=osandov.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=osandov-com.20230601.gappssmtp.com header.i=@osandov-com.20230601.gappssmtp.com header.b="T/rdvJQU" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-7ea6f99e6eeso284615a12.1 for ; Fri, 15 Nov 2024 09:57:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osandov-com.20230601.gappssmtp.com; s=20230601; t=1731693435; x=1732298235; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pPMynzIfXj/zMSO4ZhSnrSnqX/mfMYS9/DB2RGzQRzQ=; b=T/rdvJQUTHLsmWGbo7np95QObUpRI7HzN7DwcwkapWC3cVURRfPlF5yCMHzAidupCo KW7wzO6PWfF8LtZdPnTbT7IYU9icWSwOwjPUlrvVqU+gX5lPUnuYnyCFNOSjXkuf+ffd 77KOlLcpjP1br6SfalzKrqdl3TyQrAKtIFI32NVUy0cVyHLH/W9Ud22XAbOX2gO0jqBH eHqrJp+2JojcEHl0VjXLm7TjaFVmtxf6jbo+BbhWdiVF9xEvyDe1RClK2Xn2WTGZb+ZR IoLigM9uO9RMLGQ0xnxAxsJGlCz3Dxxrgq2lyYJKc+/aOIokFed5aBF6vCgYfCaYbm0S UjgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731693435; x=1732298235; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pPMynzIfXj/zMSO4ZhSnrSnqX/mfMYS9/DB2RGzQRzQ=; b=fAa3hn/SuSi2/MySogCNhcg4o0Xe9ZrzOqBO4kkVnHxaVp6fRNWxqJYmhC6eb/voyM Gmoj+Ke0UhFBViFIWUoB/HAMLNi96BvGOEb3UmmU+w12x06yVEchliotwPjQZl33I0u+ YmB4pGufVNrl3N+8Az11/5ubWv/T3OPMI6s5ye4ys4+k9e3HFlbAXtL96S50AtkkibYi 8iFIIWW4jS4nY03qzaZMPe/rZaunKL3KTWiZjW1RNT/PDLT/gXrT+zwVKzslupPEr4Y3 fyTnHpFTNFmV26MIYqf8nuvpE2YsbDNmJFgLYaili6O3lHsjDnpLz1ylMlvQjnJ39bNI Ju1Q== X-Forwarded-Encrypted: i=1; AJvYcCXW43ji+Qrwl02mkY8fThmSfVwdKue7exWxJFzVCjx/08quOCT/BbNchhm8fMkMRTEHp6c5jUpFbux8wRU=@vger.kernel.org X-Gm-Message-State: AOJu0YzX+MOyPjA39x6zxFMS0RQKpBvqaRXGUSxxNbCBnrQAxwmVvvHe Rz4wyty3xLT5OZfHB0EKOaxpacb8Lut5EEiP+R/iBdltZ0vqxSb85xE1xESB4uE= X-Google-Smtp-Source: AGHT+IFxT+B+vMFlR0BBju7TkQiKChJdJTO0QJor6trNTdWqEqoACrtnOTxsAxhAkxPiZV7G9qlR0w== X-Received: by 2002:a05:6a21:6d92:b0:1d9:14b4:9bf2 with SMTP id adf61e73a8af0-1dc909b622amr2399351637.0.1731693434983; Fri, 15 Nov 2024 09:57:14 -0800 (PST) Received: from telecaster ([2620:10d:c090:500::7:3740]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7f8c1c2c505sm1542663a12.18.2024.11.15.09.57.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Nov 2024 09:57:14 -0800 (PST) Date: Fri, 15 Nov 2024 09:57:12 -0800 From: Omar Sandoval To: Daniel Thompson Cc: Doug Anderson , Jason Wessel , Amal Raj T , Stephen Brennan , kgdb-bugreport@lists.sourceforge.net, linux-serial@vger.kernel.org, linux-debuggers@vger.kernel.org Subject: Re: kgdb replacing newline with CRLF in custom query response Message-ID: References: <20241115144933.GB4408@aspen.lan> Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241115144933.GB4408@aspen.lan> On Fri, Nov 15, 2024 at 02:49:33PM +0000, Daniel Thompson wrote: > On Fri, Nov 08, 2024 at 09:37:32AM -0800, Doug Anderson wrote: [snip] > > Bleh. It _probably_ wouldn't be a big deal to do the LF -> CRLF for > > all these, but I don't know for sure. I guess worst case you could add > > some flag in the "dbg_io_ops" and figure out how to set it just for > > UARTs? > > I find myself in a similar position to Doug. > > It sounds reasonable to move the CR synthesis into kdb_msg_write() but I > also am not certain the other polling backends will handle this correctly. > > However I did apply the following patch and run a few tests and it all > looks good. Specifically there are no regressions from the kgdb test > suite although that's unsurprising since that suite exclusively tests > the serial port. I also fired up the kdb,kms polling backends on x86 > and verified that I didn't get double line feeds in kdb (I did not). > > That means I'd certainly accept patches based on Doug's idea and if it > proves later that we have to revert and add a new dbg_io_ops pointer to > switch the handler between binary and ascii modes then so be it! Perfect, thanks for testing this, Daniel. Amal will include a preparatory patch along those lines when he sends the VMCOREINFO packet patch. Thanks, Omar