Re: [PATCH v1 1/1] serial: 8250: Move CE4100 quirks to a module under 8250 driver

[Jiri Slaby <jirislaby@kernel.org>]

On 27. 06. 25, 20:25, Andy Shevchenko wrote:
> There is inconvenient for maintainers and maintainership to have
> some quirks under architectural code. Move it to the specific quirk
> file like other 8250-compatible drivers do.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Nice.

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>

Just two nits (one suggestion actually) below. Ignore if you won't 
resubmit for some other reasons...

> --- a/arch/x86/include/asm/ce4100.h
> +++ b/arch/x86/include/asm/ce4100.h
> @@ -4,4 +4,10 @@
>   
>   int ce4100_pci_init(void);
>   
> +#ifdef CONFIG_SERIAL_8250
> +void __init sdv_serial_fixup(void);
> +#else
> +static inline void sdv_serial_fixup(void) {};

Superfluous ;.

> +#endif
> +
>   #endif
> --- a/arch/x86/platform/ce4100/ce4100.c
> +++ b/arch/x86/platform/ce4100/ce4100.c
...
> @@ -31,97 +24,6 @@ static void ce4100_power_off(void)
...
> -static u32 ce4100_mem_serial_in(struct uart_port *p, unsigned int offset)
> -{
> -	u32 ret, ier, lsr;
> -
> -	if (offset != UART_IIR)
> -		return mem_serial_in(p, offset);
> -
> -	offset <<= p->regshift;
> -
> -	ret = readl(p->membase + offset);

Just noticed: why the two above lines are not one:
ret = mem_serial_in()?

Or in fact the whole function intro:
ret = mem_serial_in(p, offset);
if (offset != UART_IIR)
   return ret;

thanks,
-- 
js
suse labs