From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 302E5C433EF for ; Tue, 15 Feb 2022 06:14:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231903AbiBOGPB (ORCPT ); Tue, 15 Feb 2022 01:15:01 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:59280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232361AbiBOGO7 (ORCPT ); Tue, 15 Feb 2022 01:14:59 -0500 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF9B5F745F; Mon, 14 Feb 2022 22:14:49 -0800 (PST) Received: by mail-ej1-f45.google.com with SMTP id lw4so11181779ejb.12; Mon, 14 Feb 2022 22:14:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=dmLGmi/jb0sxVvWxeOL0tvmCWKAWUGwcOpsWGkrfDD4=; b=vEYcqR/WbLyVaIaxBOQMCwJ3B/shJjEoQoYJyInVyJJt8qOI0WVISK8BEOhgIc+I08 0pQCDSMrWOVPmgRG0nZlIQAdfUui+4ph1pw5jsCoD1DFQKurQ7oZCHsotMxQxwRMfkN8 CAJENVPcJHfbB7RnUOnfJfcnXZXduQ8fpYyKGBj/rFzQWicjnEuyNSQ8hVL01x5n7S4b +6n7wDV22TelZm4caycnmmLQqB7DOJKwqGUaEf4quJweJwVl6Zu4lWRe3V7aTln2q/JY SSQy/hgUJtDE0B5nc1nh1TjXhtrkuH101ym/GMBNo4r3WFHLauJxccORy8+DZRRtX8BZ Zjxw== X-Gm-Message-State: AOAM530pEFamNSuh8yXNgc6xPttAhZWG2KqF62brmkZcHz+VHJ6yQpkT XzTyKOBu7RR4VTRgqWArJOs= X-Google-Smtp-Source: ABdhPJyKYhLgz9cMjm/zKM9LTSN6EcKQmbtwOxntWyQ0i0XlaEcmgIzQMi1BNZ0JQ1KQPqkEhAq6GQ== X-Received: by 2002:a17:907:6d94:: with SMTP id sb20mr1739357ejc.375.1644905688362; Mon, 14 Feb 2022 22:14:48 -0800 (PST) Received: from ?IPV6:2a0b:e7c0:0:107::49? ([2a0b:e7c0:0:107::49]) by smtp.gmail.com with ESMTPSA id h6sm6727577edb.5.2022.02.14.22.14.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Feb 2022 22:14:47 -0800 (PST) Message-ID: Date: Tue, 15 Feb 2022 07:14:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH] tty: serial: add missing pci_dev_put() before return Content-Language: en-US To: Qing Wang , Greg Kroah-Hartman , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org References: <1644890472-65306-1-git-send-email-wangqing@vivo.com> From: Jiri Slaby In-Reply-To: <1644890472-65306-1-git-send-email-wangqing@vivo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On 15. 02. 22, 3:01, Qing Wang wrote: > From: Wang Qing > > pci_get_slot() increases its reference count, the caller must > decrement the reference count by calling pci_dev_put() > > Signed-off-by: Wang Qing > --- > drivers/tty/serial/pch_uart.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/pch_uart.c b/drivers/tty/serial/pch_uart.c > index f0351e6..da5a276 > --- a/drivers/tty/serial/pch_uart.c > +++ b/drivers/tty/serial/pch_uart.c > @@ -723,7 +723,7 @@ static void pch_request_dma(struct uart_port *port) > if (!chan) { > dev_err(priv->port.dev, "%s:dma_request_channel FAILS(Tx)\n", > __func__); > - return; > + goto out; > } > priv->chan_tx = chan; > > @@ -739,13 +739,16 @@ static void pch_request_dma(struct uart_port *port) > __func__); > dma_release_channel(priv->chan_tx); > priv->chan_tx = NULL; > - return; > + goto out; > } > > /* Get Consistent memory for DMA */ > priv->rx_buf_virt = dma_alloc_coherent(port->dev, port->fifosize, > &priv->rx_buf_dma, GFP_KERNEL); > priv->chan_rx = chan; > + > +out: > + pci_dev_put(dma_dev); Again, dma_dev is stored to an internal structure and shouldn't be freed now. > } > > static void pch_dma_rx_complete(void *arg) -- js suse labs