From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: yunhui cui <cuiyunhui@bytedance.com>
Cc: ilpo.jarvinen@linux.intel.com, gregkh@linuxfoundation.org,
jirislaby@kernel.org, john.ogness@linutronix.de,
pmladek@suse.com, arnd@arndb.de, namcao@linutronix.de,
benjamin.larsson@genexis.eu, schnelle@linux.ibm.com,
heikki.krogerus@linux.intel.com, markus.mayer@linaro.org,
tim.kryger@linaro.org, matt.porter@linaro.org,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [External] Re: [PATCH v3] serial: 8250: fix panic due to PSLVERR
Date: Tue, 22 Apr 2025 10:44:17 +0300 [thread overview]
Message-ID: <aAdI0SH-mz1Uf4d-@smile.fi.intel.com> (raw)
In-Reply-To: <CAEEQ3wnEu2o+h2RY4rTGYR0yMX2EcX+7SdciqfzV3VLGWFyG3A@mail.gmail.com>
On Mon, Apr 21, 2025 at 10:55:05AM +0800, yunhui cui wrote:
> On Mon, Apr 14, 2025 at 4:47 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Mon, Apr 14, 2025 at 11:14:50AM +0800, Yunhui Cui wrote:
...
> > This patch seems need split to three. See below.
...
> > > --- a/drivers/tty/serial/8250/8250_dw.c
> > > +++ b/drivers/tty/serial/8250/8250_dw.c
> >
> > Changes here deserve the separate patch (patch 1).
>
> Splitting into a patchset is fine. What does "patch 1" refer to here?
A new series out of three patches, the above change looks good to be placed in
patch 1/3 in that _new_ series. Same for patch 2/3 and 3/3 below.
...
> > > + /*
> > > + * Serial_in(p, UART_RX) should be under port->lock, but we can't add
> >
> > serial_in()
>
> Okay.
>
> > > + * it to avoid AA deadlock as we're unsure if serial_out*(...UART_LCR)
> > > + * is under port->lock.
> > > + */
> > > + lockdep_assert_held_once(&p->lock);
...
> > > + uart_port_lock_irqsave(port, &flags);
> >
> > And one patch (patch 3) about locking.
>
> Okay.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-04-22 7:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 3:14 [PATCH v3] serial: 8250: fix panic due to PSLVERR Yunhui Cui
2025-04-14 8:47 ` Andy Shevchenko
2025-04-21 2:55 ` [External] " yunhui cui
2025-04-22 7:44 ` Andy Shevchenko [this message]
2025-04-14 11:41 ` Ilpo Järvinen
2025-04-16 12:04 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAdI0SH-mz1Uf4d-@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=benjamin.larsson@genexis.eu \
--cc=cuiyunhui@bytedance.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=markus.mayer@linaro.org \
--cc=matt.porter@linaro.org \
--cc=namcao@linutronix.de \
--cc=pmladek@suse.com \
--cc=schnelle@linux.ibm.com \
--cc=tim.kryger@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox