From: Petr Mladek <pmladek@suse.com>
To: Ryo Takakura <ryotkkr98@gmail.com>
Cc: john.ogness@linutronix.de, Jason@zx2c4.com,
gregkh@linuxfoundation.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org, lkp@intel.com,
oe-lkp@lists.linux.dev, oliver.sang@intel.com
Subject: Re: [PATCH] rslib: Add scheduling points during the test
Date: Mon, 12 May 2025 13:47:08 +0200 [thread overview]
Message-ID: <aCHfvBOY0vQ58uaC@pathway.suse.cz> (raw)
In-Reply-To: <20250510013515.69636-1-ryotkkr98@gmail.com>
On Sat 2025-05-10 10:35:15, Ryo Takakura wrote:
> The test has been prone to softlockup but stayed unnoticed because
> of the printk calls during the test resets the soflockup watchdog by
> calling touch_nmi_watchdog(). With the commit b63e6f60eab4 ("serial:
> 8250: Switch to nbcon console"), the printk calls no longer suppress
> the softlockup and warnings can be observed more evidently that shows
> the test needs more scheduling points.
>
> Provide scheduling points by adding cond_resched() for each test
> iteration on their up to/beyond error correction capacity.
>
We should add here:
Reported-by: kernel test robot <oliver.sang@intel.com>
Closes: https://lore.kernel.org/oe-lkp/202501221029.fb0d574d-lkp@intel.com
> Signed-off-by: Ryo Takakura <ryotkkr98@gmail.com>
Otherwise, it looks good to me:
Reviewed-by: Petr Mladek <pmladek@suse.com>
Thanks a lot for nailing it down.
Best Regards,
Petr
next prev parent reply other threads:[~2025-05-12 11:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-10 1:35 [PATCH] rslib: Add scheduling points during the test Ryo Takakura
2025-05-12 8:16 ` John Ogness
2025-05-12 13:54 ` Ryo Takakura
2025-05-12 11:47 ` Petr Mladek [this message]
2025-05-12 13:57 ` Ryo Takakura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCHfvBOY0vQ58uaC@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=Jason@zx2c4.com \
--cc=gregkh@linuxfoundation.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
--cc=ryotkkr98@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox