Re: [PATCH v9 06/10] serial: sh-sci: Use private port ID

Geert Uytterhoeven
2025-05-23T09:46:40Z

On Thu, 15 May 2025 at 16:19, Thierry Bultel
<thierry.bultel.yh@bp.renesas.com> wrote:
> New port types cannot be added in serial_core.h, which is shared with
> userspace.
> In order to support new port types, the coming new ones will have
> BIT(7) set in the id value, and in this case, uartport->type is
> set to PORT_GENERIC.
> This commit therefore changes all the places where the port type is
> read, by not relying on uartport->type but on the private
> value stored in struct sci_port.
>
> Signed-off-by: Thierry Bultel <thierry.bultel.yh@bp.renesas.com>
> ---
> Changes v8->v9:
> - Shrunk length od type & regtype
> - Uses BIT(7) in id value
> - Set sci_ports[0].type & sci_ports[0].regtype in scix_early_console_setup

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds