From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Abinash Singh <abinashsinghlalotra@gmail.com>
Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org,
sunilvl@ventanamicro.com, arnd@arndb.de,
u.kleine-koenig@baylibre.com, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] tty: serial/8250: Fix build warning in serial8250_probe_platform()
Date: Wed, 6 Aug 2025 01:20:23 +0300 [thread overview]
Message-ID: <aJKDp1LBpzswp5lX@smile.fi.intel.com> (raw)
In-Reply-To: <20250805195155.742004-2-abinashsinghlalotra@gmail.com>
On Wed, Aug 06, 2025 at 01:21:55AM +0530, Abinash Singh wrote:
> The function serial8250_probe_platform() in 8250_platform.c triggered a
> frame size warning:
> drivers/tty/serial/8250/8250_platform.c: In function ‘serial8250_probe_platform.isra’:
> drivers/tty/serial/8250/8250_platform.c:201:1: warning: the frame size of 1184 bytes is larger than 1024 bytes [-Wframe-larger-than=]
>
> This patch reduces the stack usage by dynamically allocating the
> `uart` structure using kmalloc(), rather than placing it on
> the stack. This eliminates the overflow warning and improves kernel
> robustness.
Same comments as per patch 1.
Also, here in the Subject you have an extra space. Actually, check output of
git log --oneline --no-merges -- drivers/tty/serial/8250/8250_platform.c
to have a hint how the Subject should look like.
...
The approach in general is okay to me.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-08-05 22:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-05 19:51 [RFC PATCH 1/2] tty: serial/8250: Fix build warning in serial8250_probe_acpi() Abinash Singh
2025-08-05 19:51 ` [RFC PATCH 2/2] tty: serial/8250: Fix build warning in serial8250_probe_platform() Abinash Singh
2025-08-05 22:20 ` Andy Shevchenko [this message]
2025-08-06 20:10 ` [PATCH v2 0/2] serial: 8250_platform: Reduce stack usage in probe functions Abinash Singh
2025-08-06 20:10 ` [PATCH v2 1/2] serial: 8250_platform: Reduce stack usage in serial8250_probe_acpi() Abinash Singh
2025-08-06 20:41 ` Andy Shevchenko
2025-08-06 20:10 ` [PATCH v2 2/2] serial: 8250_platform: Reduce stack usage in serial8250_probe_platform() Abinash Singh
2025-08-06 20:43 ` Andy Shevchenko
2025-08-06 20:39 ` [PATCH v2 0/2] serial: 8250_platform: Reduce stack usage in probe functions Andy Shevchenko
2025-08-06 21:51 ` [PATCH v3 " Abinash Singh
2025-08-06 21:51 ` [PATCH v3 1/2] serial: 8250_platform: Reduce stack usage in serial8250_probe_acpi() Abinash Singh
2025-08-06 21:51 ` [PATCH v3 2/2] serial: 8250_platform: Reduce stack usage in serial8250_probe_platform() Abinash Singh
2025-08-09 9:47 ` [PATCH v3 0/2] serial: 8250_platform: Reduce stack usage in probe functions Andy Shevchenko
2025-08-05 22:17 ` [RFC PATCH 1/2] tty: serial/8250: Fix build warning in serial8250_probe_acpi() Andy Shevchenko
2025-08-06 7:01 ` Arnd Bergmann
2025-08-06 21:06 ` Abinash Singh
2025-08-07 5:25 ` Jiri Slaby
2025-08-07 6:43 ` Jiri Slaby
2025-08-07 7:37 ` Jiri Slaby
2025-08-07 11:52 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJKDp1LBpzswp5lX@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=abinashsinghlalotra@gmail.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sunilvl@ventanamicro.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox