From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D191224234 for ; Thu, 21 Aug 2025 15:13:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755789192; cv=none; b=F8W3Bt/gFM9XShJZn4yU7Q7zSUVih9k+Ol+Aw1n3aqTl05yDWaPsS+wMcbRV0tzrn/xBfmXcxJyBuzpwfebWoA9sVWXglofYAxbTP0rbuIcTeEsFDamawTqtdCj6UwGjkJDSEy0/MrMU9yxRCBkhYEVlmWe60CTA7nqpKpqeb98= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755789192; c=relaxed/simple; bh=9nQwhppjTEwgUcisyV4d7XyXTyKaChRyMGDsYQad9o8=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kw8PVXKeBogmtcEeNTeD8z5HOPKyKolQQ89YIxmVUg396ON7BDS8RxM9/LZwYOu761m46l4Va5gmcmGMGuDMuMqTj7/mjBIOtYAY9OAcCfRn9UUqHA6ePeg3QZqpFZz8Exw1a28R61yDim//ecjpEKXxvCfT+yjB4zNFcMBo0eU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=G4Ns05Zt; arc=none smtp.client-ip=209.85.208.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="G4Ns05Zt" Received: by mail-ed1-f66.google.com with SMTP id 4fb4d7f45d1cf-6188b5ae1e8so1519540a12.0 for ; Thu, 21 Aug 2025 08:13:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1755789188; x=1756393988; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=+xtxRuaoXngMWzDes/bLKJ29G8INr9oKLKpCWom6nFQ=; b=G4Ns05ZtejOdEM1fPpWd1dKNjGt+h7dkwglwxgHpPFOmWbvAsf3OWICaSmQiL3ZFtq sT2gVGjcN4BZbJF7YNgiWsCDIk0ziesqptb8RcUaIxob66oELeYFerX8SU2Dr2KeXMvu 5dcp3DTefexDtsPaWuypX1MZgV91Ug6vQT8Nt4s/Wi16DtiAsryb3fPicbeo/YkeVjLT kYc1cyHHwKzEQYNw9Ls+xdjF9IVjxB9zvOKey3oI1b2WstiCMSl5gNYswiwLv3eFmy4+ w/NE4w3in73iilQVvtScRGusvocaFJROUmDo+JUksKEWrAC3fdFSOKtZayT52COYMDlK DC7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755789188; x=1756393988; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+xtxRuaoXngMWzDes/bLKJ29G8INr9oKLKpCWom6nFQ=; b=mew+pfHTwsc0JZpGKKKSUpMfqt1grJAuhcVFvaZb7NVgpdCXnuwlDv1AXeogQCDeY/ 0+PEzvHzx8EO+ESXcY2aL+A0ARgWSgCr/JZeTF4u2J7wWmnkoNTFwmF/lnD2a18NKRrg 8wL6wmCON3vH0yAjPed0qDvZ0Kb6k7Enz1hPAS95Un2wFucYN//B2HxcRkm8YEhlU2Lr ZW5BXAfl/uE9080NkQBTNtwKjT9KTcDDooAkNYZUmR4PYr2gLu1bzpPdleR6j+eL6JGA DDTGYfjNuJH9Bj3V6Ds5QL4ZbzI+nikJb1DESWUTlWJsg8HXjOn01PwqQVXG6+0IUArv Oy8A== X-Forwarded-Encrypted: i=1; AJvYcCVyl48T78DFaT/8nDcCS+Bt5Y75VM5vNxuT6lExCJqtqXhghJJ8Y7fTHUCXgVg2f9dCrGq6k2XfkCj+tGU=@vger.kernel.org X-Gm-Message-State: AOJu0YwyhHzupnUitOI2fEIYHMjcF0o1RML4SlOfibZ9hYKRnB0R1h6w fG7IWZUhFEjy4oyflvO0E1yRpvMGU6bb6PrGnzZNqejqiAvdJLRAPs4bFU2umvscbmI= X-Gm-Gg: ASbGnctXB2bpVzXpp3aWddtRrtVp1BCK/tukTHpG0fl2OSKb4NrcPtGuBO9qt5eRiih UfC/6zO5dc0DldUoNN14Jjb4uKiaJq+ba52ghBn6kiMHQztBUQXsWwuFIe1g5dONsRBPjvppeU9 U7zuKDOX1DC2G2blVR1atbj1qemnOCBN3XM0rJvoOhlq3kK105TNIIKTITRsMgTfzs+QS0GAqSC r3JuPoFtjFwOhIchJSh/+o84tiVmD5xTayAbpIRw6yRgamZhPzsn7tdZ6NG0NITpG/vMZodlrLv fhnnaQUdFh2pSLmwzIssalhFo2D5RcsGA16O+TVlCEdhlVyzGUKwxPK08IznMmaVF70O8q3QOOI NitsL2dQsI7xhpPxTCHBmXPsnvQbE+W5W1bjiZtJj9x+7npFA+2QOcMlD/OQm X-Google-Smtp-Source: AGHT+IET+pViMkmHfWuU+dAIph0lKCRKrp1cWSJUrymAHEUx2uNDRZI8YqflErDfwiyzgFbu3IhI8g== X-Received: by 2002:a05:6402:84f:b0:61a:2cac:890c with SMTP id 4fb4d7f45d1cf-61bf86ef69amr2362795a12.13.1755789187656; Thu, 21 Aug 2025 08:13:07 -0700 (PDT) Received: from localhost (host-79-36-0-44.retail.telecomitalia.it. [79.36.0.44]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-61a8ca8660esm3796686a12.10.2025.08.21.08.13.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Aug 2025 08:13:07 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Thu, 21 Aug 2025 17:14:59 +0200 To: Krzysztof Kozlowski Cc: Andrea della Porta , linus.walleij@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, florian.fainelli@broadcom.com, wahrenst@gmx.net, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , iivanov@suse.de, svarbanov@suse.de, mbrugger@suse.com, Jonathan Bell , Phil Elwell , Ulf Hansson , Broadcom internal kernel review list , Al Cooper , linux-mmc@vger.kernel.org, Jiri Slaby , linux-serial@vger.kernel.org Subject: Re: [PATCH 2/6] dt-bindings: serial: Add clock-frequency property as an alternative to clocks Message-ID: References: <419658ce1a1009c6f8b7af22a02b278cd695dab0.1754924348.git.andrea.porta@suse.com> Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Krzysztof, On 14:02 Tue 12 Aug , Krzysztof Kozlowski wrote: > On 11/08/2025 17:19, Andrea della Porta wrote: > > The UARTA controller on BCM2712 connected to Bluetooth chip does not > > Bluetooth chip does not ask... > > > mandiatorily ask for a clock connected to the high speed baud generator. > > This is, in fact, an optional clock in the driver. > > ... or driver does not ask? > > Please describe here hardware. > > > > > > As an alternative, the call to uart_read_port_properties() ensures that > > just a simple 'clock-frequency' property can be specified for the clock > > value. > > Don't describe drivers. Describe hardware. I will try to test whether the driver can just work specifying clock instead of clock-frequency in teh DTS, so there will be no need to amend the bindings. Many thanks, Andrea > > > > > Amend the bindings to allow to either specify clocks or clock-frequency. > > > > Signed-off-by: Andrea della Porta > > --- > > .../bindings/serial/brcm,bcm7271-uart.yaml | 19 +++++++++++++++++-- > > Please use subject prefixes matching the subsystem. You can get them for > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory > your patch is touching. For bindings, the preferred subjects are > explained here: > https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters > > > > 1 file changed, 17 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/serial/brcm,bcm7271-uart.yaml b/Documentation/devicetree/bindings/serial/brcm,bcm7271-uart.yaml > > index 89c462653e2d..96697b1428bd 100644 > > --- a/Documentation/devicetree/bindings/serial/brcm,bcm7271-uart.yaml > > +++ b/Documentation/devicetree/bindings/serial/brcm,bcm7271-uart.yaml > > @@ -40,7 +40,15 @@ properties: > > - const: dma_tx > > - const: dma_intr2 > > > > + clock-frequency: > > + description: > > + The input clock frequency for the UART, Either this or clocks must be > > + specified. > > Anyway, don't open-code schema in free form text. > > That's legacy property. You need clear explanation why. > > > + > > clocks: > > + description: > > + High speed baud rate clock. Either this or clock-frequency must be > > + specified. > > Drop last sentence, Anyway, don't open-code schema in free form text. > First sentence seems redundant anyway. > > > > minItems: 1 > > I'll fix this. > > > > > clock-names: > > @@ -61,11 +69,18 @@ required: > > - compatible > > - reg > > - reg-names > > - - clocks > > - - clock-names > > - interrupts > > - interrupt-names > > > > +oneOf: > > + - allOf: > > + - required: > > + - clocks > > + - required: > > + - clock-names > > + - required: > > + - clock-frequency > > + > > unevaluatedProperties: false > > > > examples: > > > Best regards, > Krzysztof