From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FE712FE065 for ; Fri, 29 Aug 2025 09:16:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756458968; cv=none; b=qO22xWAhFuR9c2TQzyNCOF3o/bc1tq+PzMbxVnlomW4uiXn32pltT+5VW+K+I/FYz6EbM/3r8GmTIkunWACgwE+Z8tyj2hIXuiTjrS6GBzzK715F+4BQb84wJNp2JdO0BXnZ5qvBrkbbf+vsucxhvsWUEoKZdgdI0idMrTSM4Dc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756458968; c=relaxed/simple; bh=cu6FrOL/sCoOgyl2T9Kd2v0r7CRxft9rcw5dMWCRLCs=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OaZqIkscxJYwOmU9x1mHkZE15NjC9WN4UL7PB8bA+CjcKIc0SpQSpgDwqJkh7m5YPJJkImemXXgqIKhHI3X+TYuaYymDRbhuZyw4RHOjLj3oYJTmSSQQmQDtsZ+K5FishjM08bVigvhY15Iab6vjzPkRWLcr4YPZw1zWcZiJrxM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=CVvL8WlP; arc=none smtp.client-ip=209.85.208.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="CVvL8WlP" Received: by mail-ed1-f68.google.com with SMTP id 4fb4d7f45d1cf-61a8c134533so3495157a12.3 for ; Fri, 29 Aug 2025 02:16:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1756458964; x=1757063764; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=GMCKh6ebU0u4Z6oifWcZMdJi/zOPW0SlqzJnGxsRIpQ=; b=CVvL8WlPwKXn0x2qEjaOLRHOB6ls/bIm9K6qwt3eVqADAPVhZgwzOXaflSEmVgbX/o uhAU3WZnEmC/OBFoEcHc+GyQy1KJHwHP882mXGXy6Mhl1Ri58nsPP9Xmelux8hVEnvwX l/pvyK9HOuPP4iXMoMHTKaULG9R1KJhrxqtcvQEcL1Qx15xWivADZ0y6ao40R9Vl6ynt tCPJPeOKTVuIx4SH9qOm2HSXUui/hm3/zt9bd0SkMSNhgTdxB63k9xE3F8TGnimuzYZt m8NCs6SVDNPnnErtN0tAMfQXq1lXIl2coV4zmuzcqpQbsvuBJGWRBsRzsVcOaDTGskPA EeJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756458964; x=1757063764; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GMCKh6ebU0u4Z6oifWcZMdJi/zOPW0SlqzJnGxsRIpQ=; b=qo1bdM/itjIdKa6ABVbY0Tu6t5jM1qUWrNEZq5Ter02qomup+yJnq4Iq/q6jWxQWa6 k4RPV0H+lzE4xyxCzSyG05/RU5VOVSSN6x8ThZbKCmZXwr6Ltx8jWF1/p9lR4nlbpfOh 6fHWGt8j0ygvmfB2A1k8cSNTAgDEPUSLsnYxnmoEmysM+YB2Wycc3gqR5hxKgyE9bgDh QjwFX/UY7ES02Xv/s6YA7bz9dKUWV7wWTGyGsOOkaSWu1u1jXhWnqnW/7e8AQ5XfmbH7 qLLX2jCq/cJCFZ4+6vcJ6Mzb5OHSLzk/ABL0QERhqs0eNuyUNjoWLKaT9qBrUZOHZX8P 274g== X-Forwarded-Encrypted: i=1; AJvYcCWqsHYZWEFhEtu/7FR9qQqyigP+dArF6D++wALBsrg5YnwebmkTm2yLICG3OO5TIT5jivkgGh3n38Kx2tc=@vger.kernel.org X-Gm-Message-State: AOJu0YxmtxbZcN0YQLa8Tc84ZyL0iZvgiWBgr2ieaZ8ykg8gmJ/2b3B/ pGjbGW/W8knfkTUeAv1B2D2JxyYEPfbJjANzfm0oRd4XMZuP3AsjpGr0bK3xQyoBapM= X-Gm-Gg: ASbGncvTZAzYzDw/jEsgxDY3lZTlkWnVM+moeNb2ONpJEq86OGU1I2yAemChunbZgys 6UVCmqvIxKGj18rH1l3yeEkoPtMW6yCkwYGvm5Xz4upoKD5cOhtZD28ALKYRgt2zpPZ6jUywLtY Wrl48WmhrmVlKMiFPuzyQB+HThsOp9BPvyNtzWJbxoGQJ5GsVDyE5o/jpmQL/o2eNDk7ofwMez1 4emg3n0M/gDTwBNZTAmNxt0bs6WpyE7KEKupGdyg7JO9El8PycRQ7C/j7FgII9gh36OzqBMJyxw dmTj7iQI4Wf32VpMWSrzuougshVstiKewCQe19t58TTK0Qf/wE7mv8XA9b5Uz7Ra+UMIlbqiwkx hdu6DSvoP7kpB9gSmS116byWShKnELsjmADSvvUfCmEaR60U1r8FHKL3LYt7uZcGiWU4O4GNZnl 5K7UZyF/ZURINgKRMO X-Google-Smtp-Source: AGHT+IEHgFynTh/fqQXSlnQVx/CrD8Li2R2KkbetyhBA2XZxZI4OAUkno3CLyIily5/Z/tnr+qqhWw== X-Received: by 2002:a17:907:970c:b0:afe:ae6c:411e with SMTP id a640c23a62f3a-afeae6c4776mr1267829366b.30.1756458964378; Fri, 29 Aug 2025 02:16:04 -0700 (PDT) Received: from localhost (host-79-36-0-44.retail.telecomitalia.it. [79.36.0.44]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afefcc1c397sm161585666b.81.2025.08.29.02.16.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Aug 2025 02:16:04 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Fri, 29 Aug 2025 11:17:58 +0200 To: "Rob Herring (Arm)" Cc: Andrea della Porta , linux-arm-kernel@lists.infradead.org, florian.fainelli@broadcom.com, Ulf Hansson , linux-gpio@vger.kernel.org, Jonathan Bell , svarbanov@suse.de, linus.walleij@linaro.org, devicetree@vger.kernel.org, linux-serial@vger.kernel.org, Catalin Marinas , conor+dt@kernel.org, Broadcom internal kernel review list , Jiri Slaby , krzk+dt@kernel.org, Al Cooper , linux-mmc@vger.kernel.org, wahrenst@gmx.net, iivanov@suse.de, mbrugger@suse.com, Will Deacon , Phil Elwell Subject: Re: [PATCH v2 0/5] Add peripheral nodes to RaspberryPi 5 DT Message-ID: References: <175641306018.2175061.15558471823903740794.robh@kernel.org> Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <175641306018.2175061.15558471823903740794.robh@kernel.org> Hi Rob, On 15:31 Thu 28 Aug , Rob Herring (Arm) wrote: > > On Thu, 28 Aug 2025 15:17:09 +0200, Andrea della Porta wrote: > > Hi, > > > > The following patches add a few peripheral DT nodes and related pin/gpio > > nodes for Raspberry Pi 5. > > > > - Patch 1: Amend the bindings to avoid DT compiler warnings. > > > > - Patch 2: Adds core pinctrl nodes and defines SD pins as a first appliance > > for the pinctrl. > > > > - Patch 3: Wires the gpio-key for power button and related gpio controller. > > > > - Patch 4: Adds DT node for WiFi. > > > > - Patch 5: Adds Bluetooth DT node. > > > > All comments and suggestions are welcome! > > > > Happy hacking! > > Ivan and Andrea > > > > > > CHANGES in V2: > > > > --- DTS --- > > > > - bcm2712.dtsi: added a proper clocks node to the uarta serial > > in order to replace the legacy clock-frequency property. As > > a result, the following patch from the previous patchset > > has been dropped since it's now useless: > > > > "dt-bindings: serial: Add clock-frequency property as an alternative to clocks" > > > > > > Andrea della Porta (1): > > dt-bindings: mmc: Add support for capabilities to Broadcom SDHCI > > controller > > > > Ivan T. Ivanov (4): > > arm64: dts: broadcom: bcm2712: Add pin controller nodes > > arm64: dts: broadcom: bcm2712: Add one more GPIO node > > arm64: dts: broadcom: bcm2712: Add second SDHCI controller node > > arm64: dts: broadcom: bcm2712: Add UARTA controller node > > > > .../bindings/mmc/brcm,sdhci-brcmstb.yaml | 2 +- > > .../dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dts | 133 ++++++++++++++++++ > > arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 55 ++++++++ > > 3 files changed, 189 insertions(+), 1 deletion(-) > > > > -- > > 2.35.3 > > > > > > > > > My bot found new DTB warnings on the .dts files added or changed in this > series. > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. > > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: > > pip3 install dtschema --upgrade > > > This patch series was applied (using b4) to base: > Base: attempting to guess base-commit... > Base: tags/next-20250828 (exact match) > > If this is not the correct base, please add 'base-commit' tag > (or use b4 which does this automatically) > > New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/broadcom/' for cover.1756386531.git.andrea.porta@suse.com: > > arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dtb: /soc@107c000000/pinctrl@7d504100: failed to match any schema with compatible: ['brcm,bcm2712c0-pinctrl'] > arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dtb: /soc@107c000000/pinctrl@7d504100: failed to match any schema with compatible: ['brcm,bcm2712c0-pinctrl'] > arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dtb: /soc@107c000000/pinctrl@7d510700: failed to match any schema with compatible: ['brcm,bcm2712c0-aon-pinctrl'] > arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dtb: /soc@107c000000/pinctrl@7d510700: failed to match any schema with compatible: ['brcm,bcm2712c0-aon-pinctrl'] > arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dtb: hvs@107c580000 (brcm,bcm2712-hvs): clocks: [[28, 4], [28, 16]] is too long > from schema $id: http://devicetree.org/schemas/display/brcm,bcm2835-hvs.yaml# > arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dtb: hvs@107c580000 (brcm,bcm2712-hvs): clocks: [[28, 4], [28, 16]] is too long > from schema $id: http://devicetree.org/schemas/display/brcm,bcm2835-hvs.yaml# > arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: /soc@107c000000/pinctrl@7d504100: failed to match any schema with compatible: ['brcm,bcm2712c0-pinctrl'] > arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: /soc@107c000000/pinctrl@7d510700: failed to match any schema with compatible: ['brcm,bcm2712c0-aon-pinctrl'] > arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: hvs@107c580000 (brcm,bcm2712-hvs): clocks: [[28, 4], [28, 16]] is too long > from schema $id: http://devicetree.org/schemas/display/brcm,bcm2835-hvs.yaml# > > For some reason I've dropped, from the previous cover letter, the phrase mentioning that this patchset depends on this patchset: https://lore.kernel.org/all/7ed0f2779829f4e63b69d8cf5cedda9f849996bc.1756372805.git.andrea.porta@suse.com/ which contains the schema. If you apply it as prerequisite, warnings should disappear. Many thanks, Andrea