linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] serial: 8250_exar: add support for Advantech 2 port card with Device ID 0x0018
@ 2025-09-24 13:41 Florian Eckert
  2025-10-27 11:58 ` Andy Shevchenko
  0 siblings, 1 reply; 2+ messages in thread
From: Florian Eckert @ 2025-09-24 13:41 UTC (permalink / raw)
  To: gregkh, jirislaby, andriy.shevchenko, pnewman,
	angelogioacchino.delregno, peterz, yujiaoliang, Eckert.Florian
  Cc: linux-kernel, linux-serial, Florian Eckert

The Advantech 2-port serial card with PCI vendor=0x13fe and device=0x0018
has a 'XR17V35X' chip installed on the circuit board. Therefore, this
driver can be used instead of theu outdated out-of-tree driver from the
manufacturer.

Signed-off-by: Florian Eckert <fe@dev.tdt.de>
---
 drivers/tty/serial/8250/8250_exar.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c
index 3c16a849b474..c682c0d0dffa 100644
--- a/drivers/tty/serial/8250/8250_exar.c
+++ b/drivers/tty/serial/8250/8250_exar.c
@@ -40,6 +40,8 @@
 #define PCI_DEVICE_ID_ACCESSIO_COM_4SM		0x10db
 #define PCI_DEVICE_ID_ACCESSIO_COM_8SM		0x10ea
 
+#define PCI_DEVICE_ID_ADVANTECH_XR17V352	0x0018
+
 #define PCI_DEVICE_ID_COMMTECH_4224PCI335	0x0002
 #define PCI_DEVICE_ID_COMMTECH_4222PCI335	0x0004
 #define PCI_DEVICE_ID_COMMTECH_2324PCI335	0x000a
@@ -1622,6 +1624,12 @@ static const struct exar8250_board pbn_fastcom35x_8 = {
 	.exit		= pci_xr17v35x_exit,
 };
 
+static const struct exar8250_board pbn_adv_XR17V352 = {
+	.num_ports	= 2,
+	.setup		= pci_xr17v35x_setup,
+	.exit		= pci_xr17v35x_exit,
+};
+
 static const struct exar8250_board pbn_exar_XR17V4358 = {
 	.num_ports	= 12,
 	.setup		= pci_xr17v35x_setup,
@@ -1696,6 +1704,9 @@ static const struct pci_device_id exar_pci_tbl[] = {
 	USR_DEVICE(XR17C152, 2980, pbn_exar_XR17C15x),
 	USR_DEVICE(XR17C152, 2981, pbn_exar_XR17C15x),
 
+	/* ADVANTECH devices */
+	EXAR_DEVICE(ADVANTECH, XR17V352, pbn_adv_XR17V352),
+
 	/* Exar Corp. XR17C15[248] Dual/Quad/Octal UART */
 	EXAR_DEVICE(EXAR, XR17C152, pbn_exar_XR17C15x),
 	EXAR_DEVICE(EXAR, XR17C154, pbn_exar_XR17C15x),

base-commit: 07e27ad16399afcd693be20211b0dfae63e0615f
prerequisite-patch-id: d226b2363004eee0962a350752df5facc0637d96
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] serial: 8250_exar: add support for Advantech 2 port card with Device ID 0x0018
  2025-09-24 13:41 [PATCH] serial: 8250_exar: add support for Advantech 2 port card with Device ID 0x0018 Florian Eckert
@ 2025-10-27 11:58 ` Andy Shevchenko
  0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2025-10-27 11:58 UTC (permalink / raw)
  To: Florian Eckert
  Cc: gregkh, jirislaby, pnewman, angelogioacchino.delregno, peterz,
	yujiaoliang, Eckert.Florian, linux-kernel, linux-serial

On Wed, Sep 24, 2025 at 03:41:15PM +0200, Florian Eckert wrote:
> The Advantech 2-port serial card with PCI vendor=0x13fe and device=0x0018
> has a 'XR17V35X' chip installed on the circuit board. Therefore, this
> driver can be used instead of theu outdated out-of-tree driver from the
> manufacturer.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-10-27 11:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-24 13:41 [PATCH] serial: 8250_exar: add support for Advantech 2 port card with Device ID 0x0018 Florian Eckert
2025-10-27 11:58 ` Andy Shevchenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).