From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A29531355C; Wed, 28 Jan 2026 13:12:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769605940; cv=none; b=U9Sv1CeUgwAZu3JfNe3GZgINUHRsiZtimoSNH9SoO4pPDWjaQoPx4oHjNE42ScHKIvz2BKZt8e7byCJP1DAFpYYBFkfTScbGXWGzn1GonhFjaRWQ0Lz+3zXv3YCNEd94HdssbF53KTNtjxdXpmrAayTQs8g6foWlwAmeQLNOydE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769605940; c=relaxed/simple; bh=caMJj5MeXWu40BTtO1svNq6KPU22GmNvoXPFEBVKB20=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eel/KJVGuryihIbhkpH1sf6E20plu1F04Rf6iT9a1JwsEbEvNwrn1z20Bo1ACGo355qgFTBtVdFnucRyvlifi8fWRqoXXgkR9doWBUbwnImXuVLVtV9JinYDjZfwhJTqJcUsvlWOmQmE0/XGo6voim3pPR1WhDkliKylCledpMU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=SlL6Pkc3; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="SlL6Pkc3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769605940; x=1801141940; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=caMJj5MeXWu40BTtO1svNq6KPU22GmNvoXPFEBVKB20=; b=SlL6Pkc37N3qzBhiLdtKoZVx/Q0OB7yetjYH0XZkC8Y6YYinUY5rtP93 wg0fEIkHUhHv/VOhwpvt3LdMTIQFWxpT6ONT7KbQHQBmL6vFKDhEwm5NA 94Lf+uUTFQTo8mY25zBHCNG3XMO1kWgV60Wlwyw+/V6Uni5mC4is19neU xQzw5aKfAQCQqbHGE0bNvaKQS0QeYh1yEZoYcBaDfMBn8IAtC5yV4PSZZ KoymJZd/nO2K5oAqgYqRTVWtWfxzx6Wa03B1VqvoC3hLo8yYHOVdvbu0U v69K3MGuldxovVXLHff1Y9/nh31Xs1y54ueGBFa4yb+QVpP6lD65Y4WA7 g==; X-CSE-ConnectionGUID: hi3sUG5cRwesQuwL/biixQ== X-CSE-MsgGUID: B3FGsmTFTMOzaOY9J3CcsA== X-IronPort-AV: E=McAfee;i="6800,10657,11684"; a="70716351" X-IronPort-AV: E=Sophos;i="6.21,258,1763452800"; d="scan'208";a="70716351" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2026 05:12:19 -0800 X-CSE-ConnectionGUID: DlRy0w6cTXCBeNHBC4xmIg== X-CSE-MsgGUID: +dp6+yVLT6ayjqdD5Av3jg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,258,1763452800"; d="scan'208";a="208501745" Received: from hrotuna-mobl2.ger.corp.intel.com (HELO localhost) ([10.245.244.196]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2026 05:12:16 -0800 Date: Wed, 28 Jan 2026 15:12:14 +0200 From: Andy Shevchenko To: Ilpo =?iso-8859-1?Q?J=E4rvinen?= Cc: Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, qianfan Zhao , Adriana Nicolae , linux-kernel@vger.kernel.org, "Bandal, Shankar" , "Murthy, Shanth" , stable@vger.kernel.org Subject: Re: [PATCH v2 1/7] serial: 8250: Protect LCR write in shutdown Message-ID: References: <20260128105301.1869-1-ilpo.jarvinen@linux.intel.com> <20260128105301.1869-2-ilpo.jarvinen@linux.intel.com> Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260128105301.1869-2-ilpo.jarvinen@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Wed, Jan 28, 2026 at 12:52:55PM +0200, Ilpo Järvinen wrote: > The 8250_dw driver needs to potentially perform very complex operations > during LCR writes because its BUSY handling prevents updates to LCR > while UART is BUSY (which is not fully under our control without those > complex operations). Thus, LCR writes should occur under port's lock. > > Move LCR write under port's lock in serial8250_do_shutdown(). Also > split the LCR RMW so that the logic is on a separate line for clarity. Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko