From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AAE5310771; Wed, 28 Jan 2026 15:45:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769615107; cv=none; b=pJNz8jJGRNF08Oa4ZO7vn2eoUlWEauMRfZdam4ajRxgdenVTD2wy7MtuHLG58ITAAYazv1pLrInjuIVMKniGyo0KEmJLcTHVt5jHnKBF/GVxRPiOEH4KKBXLmoZnR3m4XHFveeNVPaOV7La0O91NirdpSCuPICkjMxqhqIRaFbU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769615107; c=relaxed/simple; bh=Hq4ghYWGfXXjqkO3CDoMOn7g6bXdQJy2aBy/83LNvh0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Y25vahW5/nQVOJSYySRXgQ50pzWK7yuCM1WUk5uyiNWWfiok2oail0B29LBzQYaVE3XHJ288QdbLSGyZZ3KBeoZ5mkeiGxiZjgbQC5/2dwFuG+/7QzNd2hF3c/XIQ3/0j6QDQ8Kx72Li2qVMB8Xw+yhvtePWfeM+9u7RX/HYFl8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=dJqIRXRe; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="dJqIRXRe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769615106; x=1801151106; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=Hq4ghYWGfXXjqkO3CDoMOn7g6bXdQJy2aBy/83LNvh0=; b=dJqIRXReTeXSfNkEvcSB6k7mPakfCjMu6fTdAfE/GfsUYubG0DQJmVy2 clpsaof+gW7zqUls2UjYALVjwdGwNgJTWule2I5dWNsDfwkAJrpsS3Dz7 glYCExzQP6nb7pn2vSwtefkcwwLGW3shvUKeCchLM7ha2qDxLGgb7iv1h cN5/TaRNK4UQN0zZ0RNnn8lhyY1FFtAKuuJCVi6s+dS+lDzm8TgjprcXJ 7fcpyQFodOU5CxB/UZJ57QovVzZjOd5y2jHMWmetTvv/LRxGhbf2zPvY9 hSBenQ2R7im1I0G8DUz+9zTCCNQMAD3YxANTqTRd1EFSfsPMP0wfAoSxe Q==; X-CSE-ConnectionGUID: rjSMdgAWTcyxm9vIo1rpGQ== X-CSE-MsgGUID: lhJbmFhLTfW8PVi3Xw+ZXA== X-IronPort-AV: E=McAfee;i="6800,10657,11685"; a="81463335" X-IronPort-AV: E=Sophos;i="6.21,258,1763452800"; d="scan'208";a="81463335" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2026 07:44:57 -0800 X-CSE-ConnectionGUID: bDJTu45wRIOJaRvU2kwvRw== X-CSE-MsgGUID: y+E5wqvTRAOcbcnfVDk5zg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,258,1763452800"; d="scan'208";a="207911922" Received: from egrumbac-mobl6.ger.corp.intel.com (HELO localhost) ([10.245.245.57]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2026 07:44:56 -0800 Date: Wed, 28 Jan 2026 17:44:53 +0200 From: Andy Shevchenko To: Ilpo =?iso-8859-1?Q?J=E4rvinen?= Cc: Greg Kroah-Hartman , "Jiri Slaby (SUSE)" , LKML , linux-serial Subject: Re: [PATCH v1 1/1] serial: 8250_port: Drop duplicate NULL check Message-ID: References: <20260128142726.128175-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Wed, Jan 28, 2026 at 05:09:31PM +0200, Ilpo Järvinen wrote: > On Wed, 28 Jan 2026, Andy Shevchenko wrote: ... > > - if (up->dma) > > - serial8250_release_dma(up); > > + serial8250_release_dma(up); > > + up->dma = NULL; > > Seems reasonable safeguard, Note, 8250_omap does the same for last 3 years. > Reviewed-by: Ilpo Järvinen Thanks! -- With Best Regards, Andy Shevchenko