From: Jiri Slaby <jirislaby@kernel.org>
To: Zijun Hu <zijun_hu@icloud.com>, Rob Herring <robh@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Zijun Hu <quic_zijuhu@quicinc.com>
Subject: Re: [PATCH v3] serdev: Refine several error or debug messages
Date: Mon, 28 Apr 2025 07:32:45 +0200 [thread overview]
Message-ID: <ac37802c-65d3-48b8-9d98-fde35986692a@kernel.org> (raw)
In-Reply-To: <20250425-fix_serdev-v3-1-2e4ea8261640@quicinc.com>
On 25. 04. 25, 14:48, Zijun Hu wrote:
> From: Zijun Hu <quic_zijuhu@quicinc.com>
>
> Refine several dev_err() and dev_dbg() messages to solve:
>
> // hardcoded device name
> dev_dbg(dev, "...dev_name_str...")
>
> // repeated device name since dev_dbg() also prints it as prefix
> dev_err(dev, "...%s...", dev_name(dev))
>
> // not concise as dev_err(dev, "...%d...", err)
> dev_err(dev, "...%pe...", ERR_PTR(err))
>
> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
This LGTM.
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
--
js
suse labs
prev parent reply other threads:[~2025-04-28 5:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 12:48 [PATCH v3] serdev: Refine several error or debug messages Zijun Hu
2025-04-28 5:32 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac37802c-65d3-48b8-9d98-fde35986692a@kernel.org \
--to=jirislaby@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=quic_zijuhu@quicinc.com \
--cc=robh@kernel.org \
--cc=zijun_hu@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox