From: Jiaqing Zhao <jiaqing.zhao@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: 8250_pci: remove unreachable code for ASIX devices
Date: Wed, 24 May 2023 19:52:00 +0800 [thread overview]
Message-ID: <aee8ff85-5716-424e-3773-33700fd90dc2@linux.intel.com> (raw)
In-Reply-To: <2023051533-harmonize-ozone-bc72@gregkh>
On 2023-05-15 11:49, Greg Kroah-Hartman wrote:
> On Mon, May 15, 2023 at 10:36:30AM +0800, Jiaqing Zhao wrote:
>>
>>
>> On 2023-05-13 18:28, Greg Kroah-Hartman wrote:
>>> On Wed, May 10, 2023 at 02:28:56PM +0000, Jiaqing Zhao wrote:
>>>> PCI_VENDOR_ID_ASIX (0x9710) is the same as PCI_VENDOR_ID_NETMOS. In
>>>> pci_serial_quirks array, the NetMos entry always takes precedence over
>>>> the ASIX entry. So the code for ASIX devices is always unreachable,
>>>> even when it was initially merged. Since the NetMos vendor driver
>>>> doesn't mention such FIFO bug, it's safe to remove the code.
>>>>
>>>> This reverts commit eb26dfe8aa7e ("8250: add support for ASIX devices
>>>> with a FIFO bug").
>>>>
>>>> Signed-off-by: Jiaqing Zhao <jiaqing.zhao@linux.intel.com>
>>>
>>> Please follow the documented Intel kernel developer requirements before
>>> you submit this again, based on the changes that process will require.
>>>
>>> thanks,
>>>
>>> greg k-h
>>
>> Sorry I am unable to find this "Intel kernel developer requirements". Is
>> there any link or contact where I can find this information? Thank you.
>
> Contact the Intel Linux developer team and they will point you at them.
> This is a company-wide requirement, it is odd that your normal "Here is
> how you can contribute to Linux!" training at Intel did not cover it?
>
> thanks,
>
> greg k-h
I contacted them and there is no reply so far. Could you please tell me if
there is any general available docs about this or point out what I'm doing
wrong in this patch? Thank you very much.
next prev parent reply other threads:[~2023-05-24 11:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 14:28 [PATCH] serial: 8250_pci: remove unreachable code for ASIX devices Jiaqing Zhao
2023-05-13 10:28 ` Greg Kroah-Hartman
2023-05-15 2:36 ` Jiaqing Zhao
2023-05-15 3:49 ` Greg Kroah-Hartman
2023-05-24 11:52 ` Jiaqing Zhao [this message]
2023-05-24 14:01 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aee8ff85-5716-424e-3773-33700fd90dc2@linux.intel.com \
--to=jiaqing.zhao@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).