Re: [PATCH v3 2/2] serial: 8250_dw: Use a fixed CPR value for UltraRISC DP1000 UART

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Wed, Apr 22, 2026 at 05:39:41PM +0800, Jia Wang wrote:
> On 2026-04-22 11:46 +0300, Andy Shevchenko wrote:
> > On Wed, Apr 22, 2026 at 11:45:44AM +0300, Andy Shevchenko wrote:
> > > On Wed, Apr 22, 2026 at 08:57:56AM +0800, Jia Wang wrote:

...

> > > > Just to confirm: since you mentioned that the preparatory patch moving
> > > > the DW_UART register defines is already in place, I don't need to move
> > > > them again, correct?
> > > > 
> > > > I will update my patch to use the DW_UART_CPR_* macros and
> > > > FIELD_PREP_CONST() accordingly, and I’m happy to add a separate patch in
> > > > the next revision to convert the Renesas .cpr_value as well.
> > > 
> > > My understanding that you want to send a patch series of 3 patches:
> > > - moving DW_UART_CPR_* values from C-file to h-file
> > > - modify existing Renesas case
> > 
> > - DT binding for new HW (patch 1 of this series)
> > 
> > > - add support for your HW (this patch in updated form)
> 
> Yes, I will follow this order and resend the series in v4.

Thanks, and since Ilpo mentioned, move all DW_UART_* register offsets/bitfields
to the header file (in patch 1 of a new series).

> > And I forgot that you have a DT binging one... So 4 patches after all.

-- 
With Best Regards,
Andy Shevchenko