From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: 박명훈 <mhun512@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Ijae Kim <ae878000@gmail.com>
Subject: Re: [PATCH] serial: max3100: unwind port allocation on add failure
Date: Tue, 28 Apr 2026 09:33:29 +0200 [thread overview]
Message-ID: <afBiybvKnYZuNfQB@black.igk.intel.com> (raw)
In-Reply-To: <20260428070742.40072-1-pakmyeonghun@bagmyeonghun-ui-MacBookPro.local>
On Tue, Apr 28, 2026 at 04:07:27PM +0900, 박명훈 wrote:
> max3100_probe() reports errors from uart_add_one_port(), but then
> continues initialization and returns success. The device is left with
> per-port state in max3100s[] even though serial core did not add the
> port.
>
> Return the uart_add_one_port() error instead. Free the per-port state
> and, when no other chips remain, unregister the UART driver that probe
> registered.
NAK.
Please, try to understand why we do like this and how important is to have at
least some of the ports available (yes, I understand that this is not a robust
solution, but it might help in the unlikely cases when some of the ports are
failed to get instantiated.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-04-28 7:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 7:07 [PATCH] serial: max3100: unwind port allocation on add failure 박명훈
2026-04-28 7:33 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afBiybvKnYZuNfQB@black.igk.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=ae878000@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mhun512@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox