From: Crescent Hsieh <crescentcy.hsieh@moxa.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org,
ilpo.jarvinen@linux.intel.com, fangpingfp.cheng@moxa.com,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 01/15] serial: 8250: split Moxa PCIe serial board support out of 8250_pci
Date: Mon, 18 May 2026 20:53:16 +0800 [thread overview]
Message-ID: <agsLvCVll66tPoFA@moxa-ThinkCentre-M90t> (raw)
In-Reply-To: <CAHp75VfFMLnLDP0V3U=4zG4Ayj71-ZgVkJsVtgNE=52tGQ963w@mail.gmail.com>
On Mon, May 04, 2026 at 04:27:44PM +0300, Andy Shevchenko wrote:
> On Mon, May 4, 2026 at 11:49 AM Crescent Hsieh
> <crescentcy.hsieh@moxa.com> wrote:
> > +static void mxpcie8250_remove(struct pci_dev *pdev)
> > +{
> > + struct mxpcie8250 *priv = dev_get_drvdata(&pdev->dev);
>
> platform_get_drvdata() IIRC
In a previous patchset, dev_get_drvdata() was suggested for similar
cases [1].
Since 8250_mxpcie is a PCI driver, could you clarify what you would
prefer here for retrieving the private data? I was not sure whether the
intention was to use dev_get_drvdata(), pci_get_drvdata(), or something
else, since platform_get_drvdata() does not seem to match this driver
type.
[1]
https://lore.kernel.org/all/CAHp75VcPanVWaLi39Wf-pq8nA+xbeJUs=v1BACz-+Sns0BVyWg@mail.gmail.com/
---
Sincerely,
Crescent Hsieh
next prev parent reply other threads:[~2026-05-18 12:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 8:48 [PATCH 00/15] serial: 8250: add MUEx50 support for Moxa PCIe boards Crescent Hsieh
2026-05-04 8:48 ` [PATCH 01/15] serial: 8250: split Moxa PCIe serial board support out of 8250_pci Crescent Hsieh
2026-05-04 13:27 ` Andy Shevchenko
2026-05-04 13:29 ` Andy Shevchenko
2026-05-18 12:53 ` Crescent Hsieh [this message]
2026-05-19 7:57 ` Andy Shevchenko
2026-05-04 8:48 ` [PATCH 02/15] serial: 8250: add Moxa MUEx50 UART port type Crescent Hsieh
2026-05-04 8:48 ` [PATCH 03/15] serial: 8250_mxpcie: enable enhanced mode and program FIFO trigger levels Crescent Hsieh
2026-05-04 15:18 ` Andy Shevchenko
2026-05-04 8:48 ` [PATCH 04/15] serial: 8250_mxpcie: enable automatic RTS/CTS flow control Crescent Hsieh
2026-05-04 8:48 ` [PATCH 05/15] serial: 8250_mxpcie: offload XON/XOFF flow control to MUEx50 hardware Crescent Hsieh
2026-05-04 15:20 ` Andy Shevchenko
2026-05-04 8:48 ` [PATCH 06/15] serial: 8250_mxpcie: add custom handle_irq callback Crescent Hsieh
2026-05-04 8:48 ` [PATCH 07/15] serial: 8250_mxpcie: speed up RX using memory-mapped FIFO window Crescent Hsieh
2026-05-04 8:48 ` [PATCH 08/15] serial: 8250_mxpcie: speed up TX " Crescent Hsieh
2026-05-04 8:48 ` [PATCH 09/15] serial: 8250_mxpcie: introduce per-port private data structure Crescent Hsieh
2026-05-04 8:48 ` [PATCH 10/15] serial: 8250_mxpcie: defer uart_write_wakeup() to workqueue Crescent Hsieh
2026-05-04 8:48 ` [PATCH 11/15] serial: 8250_mxpcie: support serial interface mode switching Crescent Hsieh
2026-05-04 8:48 ` [PATCH 12/15] serial: 8250: allow low-level drivers to override break control Crescent Hsieh
2026-05-04 8:48 ` [PATCH 13/15] serial: 8250_mxpcie: add break support for RS485 using MUEx50 features Crescent Hsieh
2026-05-05 9:25 ` Andy Shevchenko
2026-05-04 8:48 ` [PATCH 14/15] serial: 8250: allow UART drivers to override rx_trig_bytes handling Crescent Hsieh
2026-05-05 9:30 ` Andy Shevchenko
2026-05-04 8:49 ` [PATCH 15/15] serial: 8250_mxpcie: implement rx_trig_bytes callbacks via MUEx50 RTL Crescent Hsieh
2026-05-05 9:34 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agsLvCVll66tPoFA@moxa-ThinkCentre-M90t \
--to=crescentcy.hsieh@moxa.com \
--cc=andy.shevchenko@gmail.com \
--cc=fangpingfp.cheng@moxa.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox