From: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
To: Kevin Cernekee <cernekee@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] tty: serial: rp2: Use named initializer for pci_device_id::driver_data
Date: Tue, 7 Jul 2026 11:09:30 +0200 [thread overview]
Message-ID: <akzB9zul5o1OMnsm@monoceros> (raw)
In-Reply-To: <20260524131905.871222-2-u.kleine-koenig@baylibre.com>
[-- Attachment #1: Type: text/plain, Size: 848 bytes --]
Hello,
On Sun, May 24, 2026 at 03:19:05PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> The .driver_data member of the struct pci_device_id array were
> initialized by list expressions relying on hidden assignment of .class
> and .class_mask in PCI_VDEVICE().
>
> Make the initialization more robust by using a named initializer. This
> robustness is relevant for a planned change to struct pci_device_id that
> replaces .driver_data by an anonymous union.
>
> This change doesn't introduce changes to the compiled pci_device_id
> array. Tested on x86 and arm64.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
This patch was sent before the merge window leading to v7.2-rc1 and got
no feedback and isn't in next. So I wonder if it's still on someone's
radar?!
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-07-07 9:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-24 13:19 [PATCH v1] tty: serial: rp2: Use named initializer for pci_device_id::driver_data Uwe Kleine-König (The Capable Hub)
2026-07-07 9:09 ` Uwe Kleine-König (The Capable Hub) [this message]
2026-07-07 12:26 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akzB9zul5o1OMnsm@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=cernekee@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox