From: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>
Cc: Florian Eckert <fe@dev.tdt.de>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v1] serial: 8250_exar: Consistently define pci_device_ids using named initializers
Date: Tue, 7 Jul 2026 11:06:07 +0200 [thread overview]
Message-ID: <akzBAgCwNho3-jpr@monoceros> (raw)
In-Reply-To: <20260522140103.769262-2-u.kleine-koenig@baylibre.com>
[-- Attachment #1: Type: text/plain, Size: 1082 bytes --]
Hello Greg,
On Fri, May 22, 2026 at 04:01:03PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> The .driver_data member of the struct pci_device_id array were
> initialized by list expressions. This isn't easily readable if you're
> not into PCI, still more given that it's hidden in macros. Using named
> initializers is more explicit and thus easier to parse for a human. And
> it's also more robust against changes to the struct definition.
>
> The mentioned robustness is relevant for a planned change to struct
> pci_device_id that replaces .driver_data by an anonymous union.
>
> Also drop a few explicit zeros that are not needed and improve
> indention.
>
> This change doesn't introduce changes to the compiled pci_device_id
> array. Tested on x86 and arm64.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
Given this patch was sent around 7.1-rc5 and missed the merge window for
7.2-rc1, I wonder if you still have it on your radar?!
It still applies fine on top of next-20260706.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2026-07-07 9:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 14:01 [PATCH v1] serial: 8250_exar: Consistently define pci_device_ids using named initializers Uwe Kleine-König (The Capable Hub)
2026-07-07 9:06 ` Uwe Kleine-König (The Capable Hub) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akzBAgCwNho3-jpr@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=fe@dev.tdt.de \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox