From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7539320CD3; Tue, 14 Jul 2026 05:25:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784006752; cv=none; b=ZsdaBOqxziHjj3G8lc5Jm/zdmhYR6ayFWvYrd7v1cNY3/0mz7CDDmg1k8ARttkASCK4+tCBtoJyo9CD+Fa5gtF2NWGbe5yhaXgVuCxd56WqW1HBDowRtPKLvf/D6Su51FIfq+cinIgKag9nRj+8+W6EXNPHjLHdIL/c2rxWaNE0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784006752; c=relaxed/simple; bh=nvUp6ixQ/4WO1OpQur/BaHDEnmJshINP5l4vlNHwZLQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=E1ArbopyttnJ6Ly3ecIHSD4RE1DQ1mk216QJZo20YKraBnyS0we+FB4xKcu5/fsZWgWrLBekds7Ln2CTDo55UCx9qvP+lG2KOeKmjdnnfzVepUlpaWeiLfJxzkHTT1gtDBkxWzofRq3t/iDg+hGPvzt2ehhmAsStcQvU3schr0A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=R4QERsU8; arc=none smtp.client-ip=198.175.65.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="R4QERsU8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1784006750; x=1815542750; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=nvUp6ixQ/4WO1OpQur/BaHDEnmJshINP5l4vlNHwZLQ=; b=R4QERsU8RS0GjehHw65G9hMQISGMMXokVI4xaMMSs+bOu9blneZkwnd6 QNmnoujEGVfkWnB8P4azE3YuxkHgmiQaqdIKPPC+/yntrdKiQ/qu4AJDn y1WHUr0pekFjz0MzMtBf+fFxEWNcbPj03PVGoHcSDGALkVQ8AofMev/C+ W+d7bfCzZo9ary/yp82+PeJXpkMjkf86la1/3alb0xl0VwceUvzAOaEwB FcFbnSjW4AZqWxU5a4Z4o6Mdu4Z/5GbISn56zMFBFCpdglX7ojsWKG/Gd ddpk41P0ipGOceLPeJMScfSSypXynLSp3MxJhlwk0+mBpcJ8S1y1Bki0Y g==; X-CSE-ConnectionGUID: 8abq/H3/RguevLrjiOw64Q== X-CSE-MsgGUID: w6gzDah7T9mHmJ2ILezqrQ== X-IronPort-AV: E=McAfee;i="6800,10657,11846"; a="84583596" X-IronPort-AV: E=Sophos;i="6.25,163,1779174000"; d="scan'208";a="84583596" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2026 22:25:48 -0700 X-CSE-ConnectionGUID: b7VVUikhRGC8aHkOs9IFiw== X-CSE-MsgGUID: Jy/VK4toSbSQTUtrikKzFA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,163,1779174000"; d="scan'208";a="280169706" Received: from fdefranc-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.246.248]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2026 22:25:36 -0700 Date: Tue, 14 Jul 2026 08:25:32 +0300 From: Tony Lindgren To: Andy Shevchenko Cc: Tony Lindgren , Praveen Talari , Greg Kroah-Hartman , Jiri Slaby , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Matthias Brugger , AngeloGioacchino Del Regno , Richard Genoud , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Orson Zhai , Baolin Wang , Chunyan Zhang , Patrice Chotard , Maxime Coquelin , Alexandre Torgue , Peter Korsgaard , Michal Simek , Aaro Koskinen , Janusz Krzysztofik , Russell King , Thomas Bogendoerfer , bjorn.andersson@oss.qualcomm.com, Konrad Dybcio , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-omap@vger.kernel.org, linux-mips@vger.kernel.org, Mukesh Kumar Savaliya , aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com Subject: Re: [PATCH 0/6] tty: serial: propagate errors from uart_ops.pm callback Message-ID: References: <20260709-add_return_check_for_uart_change_pm-v1-0-e85c6ffa8ec4@oss.qualcomm.com> <20260710043746.GM30058@atomide.com> Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jul 13, 2026 at 02:21:24PM +0300, Andy Shevchenko wrote: > On Mon, Jul 13, 2026 at 12:29:20PM +0300, Tony Lindgren wrote: > > On Fri, Jul 10, 2026 at 07:37:46AM +0300, Tony Lindgren wrote: > > > * Andy Shevchenko [260709 10:38]: > > > > Note, that Tony (you have him in the Cc list) did a lot for some corner cases > > > > with that and we still have them IIRC. Tony, do you know what is the state of > > > > affairs with runtime PM for UART? > > > > > > The RX side of things should work for hardware that can wake up to an incoming > > > event. Linux for sure needs more work to properly handle the various corner case > > > TX wake-up of a PM runtime idled UART. I'm mostly offline until Monday though, > > > will check my notes for more details next week. > > > > For the TX side handling, my understanding is that at least uart_update_mctrl() > > needs to call PM runtime resume and put autosuspend. And we should assume > > uart_update_mctrl() can sleep to resume the PM runtime suspended serial port. > > > > For drivers, the callers of uport->ops->get/set_mctrl() should be updated > > to use uart_update_mctrl() where possible. And the remaining ones that cannot > > sleep should be fixed so they can sleep or have PM runtime disabled. > > > > Anybody have better ideas? > > I don't, but the above sounds like a plan. Is it a big task? I can help with > something in that area, perhaps Ilpo also would be able to participate. Not sure how much changes are involved. Maybe it's safer to set up a runtime PM enabled wrapper for uart_update_mctrl() and then start updating the uart_update_mctrl() and get/set_mctrl() callers one at a time to make them runtime PM aware.