From: Julia Lawall <julia.lawall@lip6.fr>
To: alan@linux.intel.com, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: question about lqasc_release_port in drivers/tty/serial/lantiq.c
Date: Mon, 26 Dec 2011 18:42:17 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.02.1112261839190.1873@localhost6.localdomain6> (raw)
The function lqasc_release_port in the file drivers/tty/serial/lantiq.c is
defined as follows:
static void
lqasc_release_port(struct uart_port *port)
{
if (port->flags & UPF_IOREMAP) {
iounmap(port->membase);
port->membase = NULL;
}
}
But port->membase is initialized using devm_ioremap_nocache, implying that
it should be freed with devm_ioremap. devm_ioremap, however, requires an
additional &pdev->dev argument. Maybe the call to iounmap is not needed
at all?
julia
reply other threads:[~2011-12-26 17:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1112261839190.1873@localhost6.localdomain6 \
--to=julia.lawall@lip6.fr \
--cc=alan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox